Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

with pipe is not working if anything passed to it! and other... #67

Closed
Et3rnal opened this issue Jul 19, 2018 · 3 comments
Closed

with pipe is not working if anything passed to it! and other... #67

Et3rnal opened this issue Jul 19, 2018 · 3 comments

Comments

@Et3rnal
Copy link

Et3rnal commented Jul 19, 2018

**I'm submitting a bug

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request

Current behavior
Through the error "Parser Error: Unexpected token ',' at column 32 in [ {{ 'Sarmad et3rnal' | with: null,null,true }} ] in ng:///TheMagicsModule

Expected behavior
Just return the text

Minimal reproduction of the problem with instructions
I'm on Angular 6, I have installed this in hope to use the "with" pipe.
I have tested other pipes in the string module and they are working just fine except for
wrap: '{{': '}}'
Which is throwing a different error "Unexpected token Lexer Error: Unterminated quote..."

@fknop
Copy link
Owner

fknop commented Jul 19, 2018

It looks like I made an error in the documentation. : should be used to separate arguments and not , which is why the parser complains.

@Et3rnal
Copy link
Author

Et3rnal commented Jul 20, 2018

Great that was easy. I was worried Angular 6 break it 💃

@Et3rnal Et3rnal closed this as completed Jul 20, 2018
@Et3rnal
Copy link
Author

Et3rnal commented Jul 20, 2018

You forget to fix the first one ?
{{'The Flash Reverse' | with: 'The' : null, true}}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants