Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#181 support tag for scalars #305

Merged
merged 12 commits into from Apr 6, 2024
Merged

#181 support tag for scalars #305

merged 12 commits into from Apr 6, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 6, 2024

This PR adds a new support for scalar tags both in deserialization and serialization.
Along with the above change, the way of handling YAML version directive (such as %YAML 1.2) has also been changed without changing the public fkYAML APIs.
Note that tags for mappings and sequences are not yet supported, but they will soon be supported.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Apr 6, 2024
@fktn-k fktn-k added this to the Release v0.3.4 milestone Apr 6, 2024
@fktn-k fktn-k self-assigned this Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit f40bc4c825b5a3492bd3a36db91b62111642dd67.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr305.zip
ID 1390900611
URL https://github.com/fktn-k/fkYAML/actions/runs/8582494221/artifacts/1390900611

@coveralls
Copy link

coveralls commented Apr 6, 2024

Pull Request Test Coverage Report for Build 8582494221

Details

  • 598 of 598 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8497698905: 0.0%
Covered Lines: 3449
Relevant Lines: 3449

💛 - Coveralls

@fktn-k fktn-k merged commit 67f5c11 into develop Apr 6, 2024
144 checks passed
@fktn-k fktn-k deleted the feature/181_support_tag branch April 6, 2024 16:59
@fktn-k fktn-k mentioned this pull request Apr 12, 2024
4 tasks
@fktn-k fktn-k mentioned this pull request Apr 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants