Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer scalar conversions #308

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Defer scalar conversions #308

merged 4 commits into from
Apr 12, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 12, 2024

In #305, YAML tags are now supported in YAML scalar nodes.
Depending on the tag type, however, unnecessary conversion could occur in the lexer before determining the parsed scalar type based on the given tag.
So, all conversions triggered by the lexer have been changed so that they are defered until the convertion result is actually requested by the deserializer.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Apr 12, 2024
@fktn-k fktn-k added this to the Release v0.3.4 milestone Apr 12, 2024
@fktn-k fktn-k self-assigned this Apr 12, 2024
Copy link

github-actions bot commented Apr 12, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit b67c07d5b5d6875426b51262e7080157254210cd.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr308.zip
ID 1409810930
URL https://github.com/fktn-k/fkYAML/actions/runs/8666942755/artifacts/1409810930

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8666942755

Details

  • 300 of 300 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8618687154: 0.0%
Covered Lines: 3452
Relevant Lines: 3452

💛 - Coveralls

@fktn-k fktn-k merged commit db6664a into develop Apr 12, 2024
144 checks passed
@fktn-k fktn-k deleted the defer_scalar_conversions branch April 12, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants