Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#181 Serialize container tags #314

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 20, 2024

This PR has added the feature of serializing container tags with related test cases (scalar tags are already supported in #305 ).
Furthermore, the format with which the serialization feature complies are added to the documentation for the basic_node::serialize function.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Apr 20, 2024
@fktn-k fktn-k added this to the Release v0.3.4 milestone Apr 20, 2024
@fktn-k fktn-k self-assigned this Apr 20, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit fedc01b2fd0c1b99e849426527be99634f77b2dc.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr314.zip
ID 1431780182
URL https://github.com/fktn-k/fkYAML/actions/runs/8763786442/artifacts/1431780182

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8763786442

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8763018124: 0.0%
Covered Lines: 3502
Relevant Lines: 3502

💛 - Coveralls

@fktn-k fktn-k merged commit bc9db54 into develop Apr 20, 2024
154 checks passed
@fktn-k fktn-k deleted the feature/181_serialize_container_tags branch April 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants