Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Akeneo TableAttributeBundle with tests #2

Closed
flagbird opened this issue Jun 28, 2018 · 4 comments
Closed

Cover Akeneo TableAttributeBundle with tests #2

flagbird opened this issue Jun 28, 2018 · 4 comments

Comments

@flagbird
Copy link
Collaborator

flagbird commented Jun 28, 2018

Currently there are still tests missing for this bundle for the PHP and Javascript part.

  • Check if the code is testable and create tests
  • Look into the need of integration tests with Akeneo, so there can be checks for BC
  • Make tests run with all supported Akeneo versions
    • For easier implementation always test with the latest patch version. This can be improved later
@amansilla
Copy link
Contributor

amansilla commented Jun 17, 2019

Maybe it will be a better idea to create separate issues for every bullet otherwise this issue will be the never ending story. Or is this here everything related to EndToEnd tests?

@flagbird
Copy link
Collaborator Author

#18 is already handling those, because the migration (and future migrations) benefits from tests.

@amansilla
Copy link
Contributor

Great, so that means this can be closed once #18 is merged.

@amansilla
Copy link
Contributor

I'll close this issue since #18 which includes tests got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants