Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Divide TileLayer by its Layer type #2326

Merged
merged 13 commits into from
Feb 9, 2023
Merged

refactor: Divide TileLayer by its Layer type #2326

merged 13 commits into from
Feb 9, 2023

Conversation

Hwan-seok
Copy link
Contributor

Description

As-is

  1. The TileLayer became too big to maintain.
  2. Some tile related classes doesn't have factory method, their creation is done in other classes with big switch-case.

To-be

  1. Divided TileLayer into its Layer type. The Layer type is determined by MapOrientaion which has a member of isometric, orthogonal, staggered, and hexagonal.
  2. Instantiation is done by factory method inside the class.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon spydon requested review from ufrshubham and a team February 6, 2023 09:17
spydon
spydon approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just two minor comments

packages/flame_tiled/lib/src/renderable_layers/tile_layers/hexagonal_tile_layer.dart Outdated Show resolved Hide resolved
packages/flame_tiled/lib/src/renderable_layers/tile_layers/tile_layer.dart Outdated Show resolved Hide resolved
@spydon
Copy link
Member

spydon commented Feb 6, 2023

@jtmcdole testing if I can assign you to review now.

Hwan-seok and others added 2 commits February 7, 2023 10:13
@Hwan-seok @spydon
Update packages/flame_tiled/lib/src/renderable_layers/tile_layers/til…
0ca37e0 
…e_layer.dart

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Fix comment location
f3bfbc2
@jtmcdole
Copy link
Contributor

jtmcdole commented Feb 7, 2023

lgtm - just style comments really. Not a fan of asserts when we don't currently provide a functional layer, but we supply a standin.

@spydon spydon added this pull request to the merge queue Feb 9, 2023
@spydon spydon removed this pull request from the merge queue due to the queue being cleared Feb 9, 2023
@spydon spydon enabled auto-merge (squash) February 9, 2023 18:12
@spydon spydon merged commit 0c14d4c into flame-engine:main Feb 9, 2023
@Hwan-seok Hwan-seok deleted the hwanseok.refactor-layers branch February 9, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole left review comments

@spydon spydon spydon approved these changes

@ufrshubham ufrshubham ufrshubham approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hwan-seok @spydon @jtmcdole @erickzanardo @ufrshubham