Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TiledAtlas.clearCache function #2592

Merged
merged 7 commits into from
Jun 29, 2023
Merged

feat: TiledAtlas.clearCache function #2592

merged 7 commits into from
Jun 29, 2023

Conversation

ASGAlex
Copy link
Contributor

@ASGAlex ASGAlex commented Jun 28, 2023

Description

Possibility to clear TiledAtlas cache. This is required after Flame.images.clearCache() call.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2585

spydon
spydon reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.
A test would be good too, to make sure that the cache is properly cleared.

doc/bridge_packages/flame_tiled/flame_tiled.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_tiled/flame_tiled.md Outdated Show resolved Hide resolved
packages/flame_tiled/lib/src/tile_atlas.dart Show resolved Hide resolved
ASGAlex and others added 3 commits June 29, 2023 12:19
@ASGAlex @spydon
Update doc/bridge_packages/flame_tiled/flame_tiled.md
3ee36a1 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@ASGAlex @spydon
Update doc/bridge_packages/flame_tiled/flame_tiled.md
cf06ac4 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@ASGAlex
docs: function description fix
3302f25
@spydon spydon changed the title feat: TiledAtlas.clearCache function. Fixes #2585 feat: TiledAtlas.clearCache function Jun 29, 2023
@spydon spydon merged commit d40fefc into flame-engine:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading any tiled map throws exceptions after using Flame.images.clearCache()
2 participants
@ASGAlex @spydon