Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create flame_markdown #2703

Merged
merged 14 commits into from
Sep 7, 2023
Merged

feat: Create flame_markdown #2703

merged 14 commits into from
Sep 7, 2023

Conversation

luanpotter
Copy link
Member

Description

Add a bridge package flame_markdown to the markdown package to allow for easily creating TextElementComponents (or TextNodes in general) using the markdown syntax.

This will vastly facilitate working with rich text, specially for simple formatting like bold and italics, without requiring the user to manually specify the node tree structure.

image

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon
Copy link
Member

spydon commented Sep 2, 2023

Niiice! I believe this was what @st-pasha had in mind when he created the text rendering system you've been fiddling with now.

@luanpotter
Copy link
Member Author

That is my theory as well, as both structures line up pretty nicely.
This coming full circle will be insanely helpful for some of my games.
I only hope, if one day @st-pasha ever blesses us again with his presence in the realms of the living, that my followup can live up to his expectations 🙇

@luanpotter luanpotter marked this pull request as ready for review September 2, 2023 20:15
@luanpotter luanpotter changed the title feat: Create flame_markdown [Proposal] feat: Create flame_markdown Sep 2, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so simple, love it!

packages/flame_markdown/example/pubspec.yaml Outdated Show resolved Hide resolved
packages/flame_markdown/lib/flame_markdown.dart Outdated Show resolved Hide resolved
packages/flame_markdown/example/pubspec.yaml Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) September 7, 2023 07:17
@spydon spydon merged commit b77c237 into main Sep 7, 2023
7 checks passed
@spydon spydon deleted the luan.md branch September 7, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants