Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add overriding of Images and Bundle in all classes #2806

Merged
merged 1 commit into from
Oct 9, 2023
Merged

feat: Add overriding of Images and Bundle in all classes #2806

merged 1 commit into from
Oct 9, 2023

Conversation

erickzanardo
Copy link
Member

Description

Some classes in flame tiled weren't using the optional Images/AssetsBundle class, this address that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team October 9, 2023 16:51
@erickzanardo erickzanardo merged commit 2df90c9 into main Oct 9, 2023
8 checks passed
@erickzanardo erickzanardo deleted the feat/ensure-override-images-bundle branch October 9, 2023 17:13
@erickzanardo erickzanardo mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzanardo @spydon