-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Migrate from RawKeyEvent
to KeyEvent
#3002
Merged
spydon
merged 6 commits into
flame-engine:main
from
domesticmouse:flutter-raw-keyboard-deprecation
Feb 15, 2024
Merged
fix!: Migrate from RawKeyEvent
to KeyEvent
#3002
spydon
merged 6 commits into
flame-engine:main
from
domesticmouse:flutter-raw-keyboard-deprecation
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires Flutter `3.19.0-0` or above
PTAL @spydon |
spydon
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, was it this straight forward? Good stuff :)
packages/flame/lib/src/events/flame_game_mixins/double_tap_dispatcher.dart
Outdated
Show resolved
Hide resolved
RawKeyEvent
to KeyEvent
RawKeyEvent
to KeyEvent
domesticmouse
commented
Jan 29, 2024
6 tasks
This should now be good to land |
renancaraujo
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, some format and analyze ci is failing though
spydon
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Flutter
3.19.0-0
or aboveDescription
First pass at migrating from
RawKeyEvent
andRawKeyboard
to
KeyEvent
andHardwareKeyboard
.Context: https://docs.flutter.dev/release/breaking-changes/key-event-migration
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues