Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Migrate from RawKeyEvent to KeyEvent #3002

Merged
merged 6 commits into from Feb 15, 2024
Merged

fix!: Migrate from RawKeyEvent to KeyEvent #3002

merged 6 commits into from Feb 15, 2024

Conversation

domesticmouse
Copy link
Contributor

Requires Flutter 3.19.0-0 or above

Description

First pass at migrating from RawKeyEvent and RawKeyboard
to KeyEvent and HardwareKeyboard.

Context: https://docs.flutter.dev/release/breaking-changes/key-event-migration

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@domesticmouse
Removing deprecated RawKeyEvent and friends
cf2e48d 
Requires Flutter `3.19.0-0` or above
@domesticmouse
Copy link
Contributor Author

PTAL @spydon

spydon
spydon reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, was it this straight forward? Good stuff :)

packages/flame/lib/src/events/flame_game_mixins/double_tap_dispatcher.dart Outdated Show resolved Hide resolved
packages/flame_lint/lib/analysis_options.yaml Outdated Show resolved Hide resolved
@spydon spydon changed the title fix: Migrate from RawKeyEvent to KeyEvent fix!: Migrate from RawKeyEvent to KeyEvent Jan 25, 2024
@spydon spydon mentioned this pull request Feb 4, 2024
Merged
6 tasks
@domesticmouse
Copy link
Contributor Author

This should now be good to land

renancaraujo
renancaraujo approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@renancaraujo renancaraujo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, some format and analyze ci is failing though

@spydon spydon merged commit 330862c into flame-engine:main Feb 15, 2024
8 checks passed
@domesticmouse domesticmouse deleted the flutter-raw-keyboard-deprecation branch February 16, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain left review comments

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@domesticmouse @spydon @renancaraujo @wolfenrain