Added a ButtonComponent #1146
Added a ButtonComponent #1146
Conversation
spydon
requested review from
wolfenrain,
erickzanardo,
luanpotter and
renancaraujo
| /// Note: You have to set the [button] in [onLoad] if you are not passing it in | ||
| /// through the constructor. | ||
| class ButtonComponent extends PositionComponent with Tappable { | ||
| late final PositionComponent? button; |
There was a problem hiding this comment.
No, because then we can't do an assertion on onMount.
There was a problem hiding this comment.
Do we need an assertion though? If a variable is declared late final and you use it before it is initialized, Dart will through an assertion error for you automatically.
There was a problem hiding this comment.
Those runtime errors are hard for the user to understand though, but maybe they are enough.
If we decide those are enough, then we need to change on all other PositionComponents that can be initialized like this too, so it is outside of the scope of this PR since it only follows the current structure.
|
Description
Since we have a
HudButtonComponentI'm adding this one for consistency.If you haven't used the
HudButtonComponentit is simply twoPositionComponents, one that shows when the button is pressed and one that shows otherwise.recording.mp4
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///) and updated/added examples indoc/examples.flutter formatand theflutter analyzedoes not report any problems.[next]inCHANGELOG.md.Draftstatus, by clicking on theReady for reviewbutton in this PR.Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
CHANGELOG.md).Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.