Fix in preprocessing for Flexi app #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranchandramohan
force-pushed
the
flexi_preprocessor
branch
from
2d9656b
to
b25ff88
Compare
The preprocessor in flang detects 1.NE.PP_NUM as a number. The fix uses the knowledge that a constant number can have atmost one dot character in it. If more than one dot character is seen then the scanning has gone too far ahead. This fix removes PP_NUM from the number detected and allows for substitution of PP_NUM with the defined preprocessor value.
kiranchandramohan
force-pushed
the
flexi_preprocessor
branch
from
b25ff88
to
8cc61d8
Compare
kiranchandramohan
requested review from
bryanpkc,
gklimowicz and
shivaramaarao
gklimowicz
approved these changes
Sep 9, 2020
|
This might be a stupid question, but why does the preprocessor think that 1.NE (or any |
This could be an artifact of the preprocessor being shared between the PGI Fortran and C/C++ compilers (and hex floating-point constants). It's also possible that it is there to handle |
|
@bryanpkc please let us know if you need further explanation or if you have concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocessor in fortran detects 1.NE.PP_NUM as a number.
The fix uses the knowledge that a constant number can have
atmost one dot character in it. If more than one dot character
is seen then the scanning has gone too far ahead.
This fix removes PP_NUM from the number detected and allows
for substitution of PP_NUM with the defined preprocessor
value.