New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for NORM2 #839
Unit tests for NORM2 #839
Conversation
norm2.F90: Contains basic unit tests. norm2_function.F90: Tests for return value as norm2 and for various kinds of arrays as argument. norm2_single_precision.F90: Tests overflow with single-precision norm2_double_precision.F90: Tests overflow with double-precision. Currently XFAILed due to flang-compiler#837 norm2_error.f90: Error tests for invalid input and arguments to norm2. Signed-off-by: Caroline Concatto <caroline.concatto@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to do the right thing on Power for LLVM 8 and LLVM 9. Approved.
Minor spelling fix as suggested in review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests ran fine in our build, and the code looks correct. Approved.
@shivaramaarao is this OK for you? The PR is a set of unit tests for the NORM2 intrinsic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the patch worked fine in our environment.
A few old PRs (listed below) which carried the old license were merged recently. This patch switches to the new license. flang-compiler#839 flang-compiler#737 flang-compiler#765 flang-compiler#815
This patch adds unit tests for NORM2.
norm2.F90: Contains basic unit tests.
norm2_function.F90: Tests for return value as norm2 and for various kinds of arrays as argument.
norm2_single_precision.F90: Tests overflow with single-precision
norm2_double_precision.F90: Tests overflow with double-precision. Currently XFAILed due to #837
norm2_error.f90: Error tests for invalid input and arguments to norm2.
Signed-off-by: Caroline Concatto caroline.concatto@arm.com