Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull 2019-10-09T10-36 Recent NVIDIA Changes #815
Improve codegen for map clause for explicitly mapped scalars, pointers and arrays. Scalars are passed by value as they are implicitly firstprivate. However, if they appear in map clause, they should be pass by reference.
LOGICAL*1 and LOGICAL*2 dummy arguments were generating incorrect LLVM IR, eventually leading to a seg fault. This is because MSZ value was being set as MSZ_WORD. Adding a case for TY_BLOG and TY_SLOG and setting MSZ_SBYTE and MSZ_SHWORD respectively generates correct LLVM IR.
Check OpenMP's target data directive while calculating array sections in map clause. Array sections are still not supported in Fortran, the whole array is sent to the device, so semantic analysis for the array section should be skipped for now. If not, compilation fails as array sections are not handled in the later phases in the compiler. The right thing to do for the front end is to skip it and gives a warning if the directive is combined with "target" construct. The compiler was not doing the right thing for "target data", "target enter/exit data". This patch adds check for them. In short this patch fixes compilation fails for the following codes: !$omp target enter data map(to:a(:,:) , b(:))
1) Add compilation flag "-m64" 2) Do not use -O2 and higher 3) Eliminate implicit constructor called at process initialization from logf and log10f for 3 constants used in the implementation of those routines for AVX2, KNL, and AVX512 ISA extensions. 4) Add header guard to runtime/libpgmath/lib/common/logf/common.h 5) Change system include header file <cmath> to <math.h>. Windows' <cmath> has an implicit dependency on runtime MSC_VER >= 1900.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.