Fix a clash between CONTIGUOUS and SAVE attribute in flang (issue #673) #968
Conversation
…ng-compiler#673) This simple patch adds CONTIGUOUS attribute to the list of attributes allowed to use along with the SAVE attribute. Signed-off-by: Paul Osmialowski <pawel.osmialowski@arm.com>
kiranchandramohan
requested review from
kiranchandramohan,
bryanpkc,
mleair and
shivaramaarao
|
@pawosm-arm This doesn't address the ordering issue, right? I didn't look in detail, but it seems that How about the conflict between |
By ordering you meant the order those attributes are given? The funny thing (I've also mentioned in the bug report) is that
Indeed.
I've looked into this just briefly, and it didn't seem to look as obvious as with CONTIGUOUS. Also, I don't have any real life code replicating that, while simultaneous use of CONTIGUOUS and SAVE has appeared recently in cp2k project's git master. |
| module contig | ||
| implicit none | ||
| integer, dimension(:), pointer, contiguous, save :: ptr | ||
| end module |
There was a problem hiding this comment.
This test case should probably be moved into test/sema/ I guess? Consider naming it contiguous.f90.
There was a problem hiding this comment.
I don't think such a detailed division of test cases would give any additional value to the classic flang, also in the past I've been placing more test cases like this one in this same directory. And adding test case to this directory does not require modifying or adding any other files.
I've deliberately avoided naming this test case 'contiguous' to prevent name clash with one of the f2008 keywords.
This simple patch adds CONTIGUOUS attribute to the list of attributes allowed to use along with the SAVE attribute.
Fixes a problem signaled in #673.