Kubernetes consolidation #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E - k8s1 files ±0 1 suites ±0 0s ⏱️ - 1m 58s For more details on these failures, see this check. Results for commit abdc52d. ± Comparison against base commit ea91049. This pull request removes 7 tests.♻️ This comment has been updated with latest results. |
moshloop
reviewed
Nov 4, 2021
api/context/context.go
Outdated
| @@ -62,3 +65,35 @@ func (ctx *Context) New(environment map[string]interface{}) *Context { | |||
| Logger: ctx.Logger, | |||
| } | |||
| } | |||
| func (ctx *Context) GetInnerCanaries(namespace string, canaryRef []k8sv1.LocalObjectReference) ([]v1.Canary, []string, error) { | |||
There was a problem hiding this comment.
Suggested change
| func (ctx *Context) GetInnerCanaries(namespace string, canaryRef []k8sv1.LocalObjectReference) ([]v1.Canary, []string, error) { | |
| func (ctx *Context) GetCanaries(namespace string, canaryRef []k8sv1.LocalObjectReference) ([]v1.Canary, []string, error) { |
moshloop
reviewed
Nov 4, 2021
moshloop
reviewed
Nov 4, 2021
checks/cloudwatch.go
Outdated
| @@ -31,7 +31,11 @@ func (c *CloudWatchChecker) Type() string { | |||
| } | |||
|
|
|||
| func (c *CloudWatchChecker) Check(ctx *context.Context, extConfig external.Check) *pkg.CheckResult { | |||
| check := extConfig.(v1.CloudWatchCheck) | |||
| updated, err := Contextualise(extConfig, ctx) | |||
There was a problem hiding this comment.
Suggested change
| updated, err := Contextualise(extConfig, ctx) | |
| updated, err := ctx.Contextualise(extConfig) |
moshloop
reviewed
Nov 4, 2021
| if err != nil { | ||
| return pkg.Fail(extConfig, ctx.Canary) | ||
| } | ||
| check := updated.(v1.CloudWatchCheck) |
There was a problem hiding this comment.
does the contextualization not need to happen on check with type information ?
There was a problem hiding this comment.
Not sure I follow. The need is to generically template any chained canary, so the function is written to take an external.Check rather than a specifically typed v1.xxCheck
…ubernetes-consolidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#341 #309
Adds a contextualise function to generically handle inserting defaults values to checks, and templating environment values into chained checks