Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Extension permission grids can be confusing #2503

Closed
dsevillamartin opened this issue Dec 20, 2020 · 1 comment · Fixed by #2593
Closed

[Tags] Extension permission grids can be confusing #2503

dsevillamartin opened this issue Dec 20, 2020 · 1 comment · Fixed by #2593
Milestone

Comments

@dsevillamartin
Copy link
Member

One can see all the tag-specific permissions in an extension's permission grid even if there are no tag-specific permissions specific to that extension.

The problem with this is that the tag-specific feature is global and not per-extension. This is made confusing by the fact that you have an X to delete tag-specific permissions for a specific tag

Permission grid of fof/drafts on Flarum Discuss
image

Users may think this is specific to the extension they're currently in the page of and may delete ALL their tag-specific perms for that tag without meaning to.

@clarkwinkelmann
Copy link
Member

I've also found a confusing counter-case.

If you add a new tag scope from the extension page, then you can't select anything in the dropdown because you first need to visit the permissions page to change the access to something different than admin under "View discussions" 🙄

Step 1
image
Step 2
image

What I think we should do:

  • Prevent creating or deleting scopes from extension page
  • Add button saying "Configure scopes" or something that leads to Permissions page
  • Hide the scope columns if none of the extension's permissions are scopable

@askvortsov1 askvortsov1 added this to the 0.1.0-beta.16 milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants