Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ssh-agent socket into the sandbox #33

Closed
mzabaluev opened this issue May 13, 2018 · 5 comments
Closed

Forward ssh-agent socket into the sandbox #33

mzabaluev opened this issue May 13, 2018 · 5 comments

Comments

@mzabaluev
Copy link
Contributor

To facilitate working with git over ssh, it would be nice if the sandbox had access to the ssh-agent socket from the user session. flatpak/flatpak#1438 says this is feasible with manual override options of flatpak run, but it would be great if the app had it out of the box.

@mzabaluev
Copy link
Contributor Author

This could alleviate #23 as well: in my usage, I'm mostly using keys enrolled into the session-provided agent.

@JeffLabonte
Copy link

I agree with @mzabaluev, that would great to be able to do so out of the box!

@nedrichards
Copy link
Member

This requires at least flatpak 0.10.3 (releases before then fail when they see unknown permissions). We only have flathub version stats from Flatpak 0.11.3 onwards, and that or newer is currently at 60% of usage. I'd love to see that get higher before we turn this on by default. (we believe the main 'offender' is CentOS/RHEL which are on 0.8.8 fwiw.)

@mzabaluev
Copy link
Contributor Author

For an individual installation, the problem can be solved persistently with
flatpak override --socket=ssh-auth com.visualstudio.code.
So only "out of the box" part is missing.

@nedrichards
Copy link
Member

Should be fixed by 4d6ea9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants