add io.mpv.Mpv #1057
add io.mpv.Mpv #1057
Conversation
|
I believe the ID should be |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5095 |
|
Build 5095 failed |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5098 |
|
Build 5098 failed |
|
bot, build io.mpv.Mpv |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5100 |
|
Build 5100 failed |
|
bot, build io.mpv.Mpv |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5102 |
|
Build 5102 failed |
|
bot, build io.mpv.Mpv |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5104 |
|
Build 5138 successful |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5173 |
|
OK then, so the only thing that stands in the way is an upstream PR pushing the appdata file - since that's generally useful for everyone on Linux, not just flatpak. Sad that upstream don't want to be involved, do you have a list of maintainers, just @paulcarroty? It'd be nice to send a PR to https://github.com/mpv-player/mpv.io as well once this is added to get on this page https://mpv.io/installation/ |
|
I imagine the reason upstream prefers snap is because its primary used from the cli and flatpak requires a different command, making all existing docs/workflows unusable. |
|
Build 5173 successful |
|
bot, build io.mpv.Mpv |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5184 |
|
Build 5184 successful |
|
bot, build io.mpv.Mpv |
|
Queued test build for io.mpv.Mpv. |
|
Started test build 5191 |
| "--device=all", | ||
| "--share=network", | ||
| "--socket=pulseaudio", | ||
| "--filesystem=host", |
There was a problem hiding this comment.
Does MPV ever need write access? If not,
| "--filesystem=host", | |
| "--filesystem=host:ro", |
There was a problem hiding this comment.
Plugins are stored in MPV config dir, which is mounted read-writable even with host:ro.
There was a problem hiding this comment.
Can you point to a specific plugin that writes to a directory outside xdg-config/xdg-data?
There was a problem hiding this comment.
Isn't it too specific use-case to expose whole filesystem for all users? Users who actually need write access to host, may add it via overrides.
There was a problem hiding this comment.
It'd be appreciated if you could stop resolving conversations that are still in progress.
There was a problem hiding this comment.
Screenshot needs write access, though I guess only to xdg-pictures.
|
Build 5191 successful |
|
Have you submitted appdata upstream or you will pretend no one asked for that? |
|
Appdata is not specific to flatpak. |
|
@paulcarroty specifically an upstream PR #1057 (comment) it doesn't have to be merged but it does have to be offered. |
|
Where does the info about that MPV developers prefer snap comes from, btw? I didn't find neither official snap package, nor issues/PRs related to it. There is only request to provide AppImage, closed with wontfix. |
|
I think its worth trying again with more detail and a PR. In those 3 years every distros app store supports this standard now. |
|
We've decided to not move forward with this at the moment. You have a history of abandoning packages here and have not been the easiest to work with so we would prefer a different maintainer for this application. I'll leave this open for a bit if anybody else wants to step up. |
ghost
mentioned this pull request
https://mpv.io/