-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Motrix #2334
Add Motrix #2334
Conversation
bot, build net.agalwood.Motrix |
Queued test build for net.agalwood.Motrix. |
Have the appdata and desktop files been submitted upstream? |
net.agalwood.Motrix.metainfo.xml
Outdated
|
||
<developer_name>AGALWOOD</developer_name> | ||
|
||
<metadata_license>MIT</metadata_license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC0 as a license for metadata is preferred. Since it's here I assume you created the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. It should be the <project_license>
net.agalwood.Motrix.yml
Outdated
@@ -0,0 +1,160 @@ | |||
app-id: net.agalwood.Motrix | |||
branch: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch: stable |
Default branch is already stable
, this is unecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
net.agalwood.Motrix.yml
Outdated
# post-install: | ||
# - chmod 644 $FLATPAK_DEST/lib/libpython2.7.so.1.0 | ||
# cleanup: | ||
# - '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't need this it's better to just remove it.
i386: | ||
env: | ||
npm_config_arch: ia32 | ||
npm_config_target_arch: ia32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neither i386
nor arm
are supported anymore by the runtime so it's unnecessary.
(it's harmless though, just clutter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, let's just leave it there? As they are supported by electron and someone might find it useful
"type": "git", | ||
"url": "https://github.com/agalwood/Motrix.git", | ||
"ref": "v1.6.10" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file isn't referenced anywhere in the manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's used to auto update the generated-sources.json
: https://github.com/flathub/flathub/pull/2334/files#diff-3db03b056e588432b22814fac93c11d44c8a4d8d958713cd2bf70b1d1d0ab48dR107
Started test build 48196 |
Build 48196 successful
|
The appdata and desktop file do not appear in any electron apps, because the information is in their |
bot, build net.agalwood.Motrix |
Queued test build for net.agalwood.Motrix. |
Started test build 48200 |
Build 48200 successful
|
This link is incorrect. This one seems to be the correct one: agalwood/Motrix#546 |
Yes. Thanks |
README.asciidoc
Outdated
@@ -0,0 +1,38 @@ | |||
= Standard Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README does not seem valid here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
/merge @agalwood |
A repository for this has been created: https://github.com/flathub/net.agalwood.Motrix You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
@barthalion |
This happens automatically – the person submitting an app is always invited. |
OK, thanks : D |
Please confirm your submission meets all the criteria