Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Motrix #2334

Closed
wants to merge 5 commits into from
Closed

Add Motrix #2334

wants to merge 5 commits into from

Conversation

proletarius101
Copy link

@proletarius101 proletarius101 commented May 15, 2021 •
edited
Loading

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: 请求打包成 flatpak agalwood/Motrix#546 (comment)
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@proletarius101 proletarius101 mentioned this pull request May 15, 2021
Closed
@proletarius101
Copy link
Author

bot, build net.agalwood.Motrix

@flathubbot
Copy link

Queued test build for net.agalwood.Motrix.

@hfiguiere
Copy link
Contributor

Have the appdata and desktop files been submitted upstream?

hfiguiere
hfiguiere requested changes May 15, 2021
View reviewed changes
net.agalwood.Motrix.metainfo.xml Outdated

<developer_name>AGALWOOD</developer_name>

<metadata_license>MIT</metadata_license>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC0 as a license for metadata is preferred. Since it's here I assume you created the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. It should be the <project_license>

net.agalwood.Motrix.yml Outdated
@@ -0,0 +1,160 @@
app-id: net.agalwood.Motrix
branch: stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branch: stable

Default branch is already stable, this is unecessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

net.agalwood.Motrix.yml Outdated
# post-install:
# - chmod 644 $FLATPAK_DEST/lib/libpython2.7.so.1.0
# cleanup:
# - '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't need this it's better to just remove it.

net.agalwood.Motrix.yml
i386:
env:
npm_config_arch: ia32
npm_config_target_arch: ia32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither i386 nor arm are supported anymore by the runtime so it's unnecessary.

(it's harmless though, just clutter)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let's just leave it there? As they are supported by electron and someone might find it useful

net.agalwood.Motrix-git.json
"type": "git",
"url": "https://github.com/agalwood/Motrix.git",
"ref": "v1.6.10"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file isn't referenced anywhere in the manifest.

Copy link
Author

@proletarius101 proletarius101 May 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's used to auto update the generated-sources.json: https://github.com/flathub/flathub/pull/2334/files#diff-3db03b056e588432b22814fac93c11d44c8a4d8d958713cd2bf70b1d1d0ab48dR107

@flathubbot
Copy link

Started test build 48196

@flathubbot
Copy link

Build 48196 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46347/net.agalwood.Motrix.flatpakref

@proletarius101
Copy link
Author

Have the appdata and desktop files been submitted upstream?

The appdata and desktop file do not appear in any electron apps, because the information is in their package.json. Those files are generated from it and I copied the corresponding information from it, too.

@proletarius101
Copy link
Author

bot, build net.agalwood.Motrix

@flathubbot
Copy link

Queued test build for net.agalwood.Motrix.

@flathubbot
Copy link

Started test build 48200

@flathubbot
Copy link

Build 48200 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46351/net.agalwood.Motrix.flatpakref

@AsciiWolf
Copy link
Contributor

AsciiWolf commented May 16, 2021 •
edited
Loading

  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Add Motrix #2334

This link is incorrect. This one seems to be the correct one: agalwood/Motrix#546

@proletarius101
Copy link
Author

  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Add Motrix #2334

This link is incorrect. This one seems to be the correct one: agalwood/Motrix#546

Yes. Thanks

barthalion
barthalion reviewed May 17, 2021
View reviewed changes
README.asciidoc Outdated
@@ -0,0 +1,38 @@
= Standard Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README does not seem valid here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@barthalion
Copy link
Member

/merge @agalwood

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/net.agalwood.Motrix

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this May 18, 2021
@agalwood
Copy link

@barthalion
Can you help invite @proletarius101 to be the collaborator of this project (https://github.com/flathub/net.agalwood.Motrix) ?

@barthalion
Copy link
Member

This happens automatically – the person submitting an app is always invited.

@agalwood
Copy link

OK, thanks : D

@proletarius101 proletarius101 deleted the motrix branch May 18, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthalion barthalion barthalion left review comments

@hfiguiere hfiguiere hfiguiere requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@proletarius101 @flathubbot @hfiguiere @AsciiWolf @barthalion @agalwood