Create org.pitivi.Pitivi.json #52

thiblahute · 2017-07-05T18:22:41Z

No description provided.

TingPing · 2017-07-05T19:30:02Z

org.pitivi.Pitivi.json

+{
+    "app-id": "org.pitivi.Pitivi",
+    "runtime": "org.gnome.Platform",
+    "runtime-version": "3.22",


Any reason why not 3.24?

Yes, this version has been developed and mostly tested on 3.22, only in current master we support 3.24 (fixed minor warning and stuff).

We also provide master (build on every commit) on http://flatpak.pitivi.org/ which is based on Sdk 3.24.

I would strongly recommend 3.24 as it has had numerous improvements like supporting theming, VAAPI support, GStreamer 1.10 and other dependencies you use, etc.

We do not want vaapi (not robust enough for us), our official development environment is flatpak and for a specific release we target a specific runtime/sdk version, changing randomly afterward is like what used to happen with distro, and this is really something I do not want.

TingPing · 2017-07-05T19:30:26Z

org.pitivi.Pitivi.json

+    "finish-args": ["--command=pitivi",
+                    "--share=ipc",
+                    "--socket=x11",
+                    "--socket=session-bus",


Ideally only grant what you need rather than blanket access.

ipc, is the onlyone that might not be required, am I missing something else?

--socket=session-bus gives you unrestricted access to the dbus session. You should be using --talk-name=foo.bar instead.

TingPing · 2017-07-05T19:30:50Z

org.pitivi.Pitivi.json

+    },
+    "modules": [
+        {
+            "name": "yasm",


This is in the Sdk.

TingPing · 2017-07-05T19:31:48Z

org.pitivi.Pitivi.json

+            "build-options": {
+              "build-args": ["--share=network"],
+              "cflags": "-O0 -g  -L/usr/lib -Lbuild/temp.linux-x86_64-3.4 -I/usr/include -I/usr/include/python3.4m/",
+              "env": {"ARCHFLAGS": "-arch x86_64"}


Flathub supports multiple arches so hardcoding this is wrong unless you only support that one arch.

Good point!

TingPing · 2017-07-05T19:32:10Z

org.pitivi.Pitivi.json

+        {
+            "name": "numpy",
+            "build-options": {
+              "build-args": ["--share=network"],


Flathub is sandboxed, you cannot grant network access. You have to fix their build system to work offline.

This applies to many of the other modules too.

Why is that? What does it change to access the network from the host or from withing the sandbox?

This was mentioned on IRC but we want everything to be reproducable and it stops any possibility of any malicious network use.

TingPing · 2017-07-05T19:32:37Z

org.pitivi.Pitivi.json

+            ]
+        },
+        {
+            "name": "meson",


This is in the 3.24 Sdk.

Right, but we do not use 3.24 :-)

Bump as it was rebased to the 3.24 Sdk.

TingPing · 2017-07-05T19:34:32Z

org.pitivi.Pitivi.json

+            ]
+        },
+        {
+            "name": "gst-plugins-good",


Gstreamer 1.10 is In the 3.24 Sdk.

If you only need to build a few extra plugins specify so in the config-opts. Same goes for most of the other gstreamer modules.

Bump as it was rebased to the 3.24 Sdk.

We need our own build of Gst as we have backported patches that are not in the 1.12 branch and we build quite many more plugins than what is provided in the Sdk.

TingPing · 2017-07-05T19:35:02Z

org.pitivi.Pitivi.json

+            "name": "pitivi",
+            "buildsystem": "meson",
+            "builddir": true,
+            "config-opts": ["--libdir=lib", "--prefix=/app"],


Don't need to pass prefix manually.

thiblahute · 2017-07-06T14:25:46Z

Updated with the following changes:

Nework grant network access to the module builds directly using setup.py
Remove wrong "--share=ipc", "--socket=session-bus" access granding
Remove --prefix from pitivi target
Add gst-transcoder as a module as using it as a subproject lead to a wrong libdir path installation (ie. it was installing to lib64/
Remove archs definition as those were not needed (hopefully Pitivi will build on more arch :-))

thiblahute · 2017-07-12T02:21:51Z

Anything missing?

barthalion · 2017-07-12T12:40:00Z

No. Looks good to me (although I dislike that you are using 3.22, but I see your point); I scheduled a test build.

TingPing · 2017-07-13T20:03:13Z

Build failed since 3.22 isn't available on the builders.

thiblahute · 2017-07-14T02:36:20Z

Build failed since 3.22 isn't available on the builders.

I tested with 3.24 and we have regression (that are fixed in master), I will try to get pitivi 0.99 released soon and update that PR.

purpleidea · 2017-07-19T11:46:34Z

Build failed since 3.22 isn't available on the builders.

Why not?

thiblahute · 2017-07-19T19:41:26Z

Why not?

Also a very good question! :-)

TingPing · 2017-07-19T19:51:28Z

Probably because nobody needed it yet and 3.24 has a lot of improvements. I imagine Alex isn't against adding it though.

purpleidea · 2017-07-19T19:52:41Z

@thiblahute

Also a very good question! :-)

Wasn't meant as sarcasm, but rather, I thought the whole point is that flatpak would allow application authors to target different runtimes, thus not breaking apps if gnome moves faster than they do for example. Personally, I think you should just get on the latest, but I understand both sides :)

thiblahute · 2017-07-19T20:37:31Z

@thiblahute

Also a very good question! :-)
Wasn't meant as sarcasm, but rather, I thought the whole point is that flatpak would allow application authors to target different runtimes, thus not breaking apps if gnome moves faster than they do for example.

I was not taking it as sarcasm, just stating that it would also be good to have.

Personally, I think you should just get on the latest, but I understand both sides :)

Well we have but it is not released yet.

@alexlarsson

Probably because nobody needed it yet and 3.24 has a lot of improvements. I imagine Alex isn't against adding it though.

(How) could we get that done?

TingPing · 2017-07-19T21:16:38Z

@thiblahute I'm curious where the regression you have is? Because they should have the same Gtk version (3.24 doesn't exist), they should have the same GStreamer since you build it yourself, etc.

thiblahute · 2017-07-19T21:18:15Z

@thiblahute I'm curious where the regression you have is? Because they should have the same Gtk version (3.24 doesn't exist), they should have the same GStreamer since you build it yourself, etc.

We have an issue in latest meson (we could workaround that), and in Gtk between 3.22.6 (Sdk 3.22.0) and 3.22.14 in the new Sdk.

TingPing · 2017-07-19T21:48:23Z

and in Gtk between 3.22.6 (Sdk 3.22.0) and 3.22.14 in the new Sdk.

Hmm, well it is probably just chance that the old Sdk didn't get those Gtk3 updates anyway. As you mention Meson is trivial to workaround.

thiblahute · 2017-09-22T13:05:38Z

OK, 0.99 is out based on the 3.24 runtime, please review again :-)

barthalion · 2017-09-24T19:01:39Z

org.pitivi.Pitivi.json

@@ -0,0 +1,497 @@
+{
+    "app-id": "org.pitivi.Pitivi",
+    "branch": "1.0",


Set it to stable or remove altogether, our CI sets it on its own.

barthalion · 2017-09-24T19:01:56Z

org.pitivi.Pitivi.json

+                    "--socket=x11",
+                    "--socket=pulseaudio",
+                    "--socket=wayland",
+                    "--socket=session-bus",


Does it need access to entire session bus?

Well, without it Pitivi doesn't start and we get:

Failed to register: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown

but I must be missing something, couldn't figure out what :-)

Probably just patch this to use the correct app-id: https://github.com/GNOME/pitivi/blob/ed321acfa2e84b67ce2ff7754ad135674b0aa74a/pitivi/application.py#L72

barthalion · 2017-09-24T19:02:21Z

org.pitivi.Pitivi.json

+    "branch": "1.0",
+    "runtime": "org.gnome.Platform",
+    "runtime-version": "3.24",
+    "finish-args": ["--command=pitivi",


Use command top level property instead.

barthalion · 2017-09-24T19:02:44Z

org.pitivi.Pitivi.json

+    "rename-icon": "pitivi",
+    "copy-icon": true,
+    "build-options": {
+        "cflags": "-O0 -g",


So, a nitpick… Why not -O2?

Removed for releases.

barthalion · 2017-09-24T19:03:06Z

org.pitivi.Pitivi.json

+          "GST_PLUGIN_SYSTEM_PATH": "/app/lib/gstreamer-1.0/",
+          "FREI0R_PATH": "/app/lib/frei0r-1/"
+        },
+        "strip": false,


It's the default.

Remains from the past :-)

barthalion · 2017-09-24T19:04:28Z

org.pitivi.Pitivi.json

+        {
+            "name": "numpy",
+            "buildsystem": "simple",
+            "ensure-writable": ["easy-install.pth"],


@TingPing does it look right to you?

He suggested the trick :-)

barthalion · 2017-09-24T19:04:48Z

org.pitivi.Pitivi.json

+            ]
+        },
+        {
+            "name": "sound-theme-freedesktop",


It's in the runtime since a while.

barthalion · 2017-09-24T19:05:51Z

org.pitivi.Pitivi.json

+        },
+        {
+            "name": "x265",
+            "cmake": true,


Please use "buildsystem": "cmake", cmake as key is marked as deprecated.

barthalion · 2017-09-24T19:06:30Z

org.pitivi.Pitivi.json

+            ]
+        },
+        {
+            "name": "gst-plugins-good",


Bump as it was rebased to the 3.24 Sdk.

barthalion · 2017-09-24T19:06:35Z

org.pitivi.Pitivi.json

+            ]
+        },
+        {
+            "name": "meson",


Bump as it was rebased to the 3.24 Sdk.

barthalion · 2017-09-24T19:11:00Z

Just now when we're about to switch to 3.26! :)

We need some things to be changed, but I started a test build though: https://flathub.org/builds/#/builders/1/builds/451

thiblahute · 2017-09-24T23:38:02Z

Just now when we're about to switch to 3.26! :)

Well, Pitivi 1.0 is not going to be based on it ;)

And thanks for the review!

TingPing · 2017-09-24T23:50:47Z

Looks like matplotlib fails.

thiblahute · 2017-09-24T23:56:58Z

To me the issue is the usage of build-args, which I am removing now. (still testing locally before updating my patches).

thiblahute · 2017-09-25T00:03:31Z

Can you trigger a rebuild please?

TingPing · 2017-09-25T00:42:54Z

https://flathub.org/builds/#/builders/1/builds/453

thiblahute · 2017-09-25T01:05:12Z

OK, works only on 64bits whch is the only one I care about for now (only tested one), I added a flathub.json so that it is the only one built for now, is that ok?

AsavarTzeth · 2017-09-25T07:01:38Z

You would need to fix lame not building on all architectures the same way as com.github.JannikHv.Gydl and org.audacityteam.Audacity.

This will be the third application that has to solve the same issue. I will hence repeat my suggestion to make it a shared module.

TingPing · 2017-09-25T09:05:46Z

@AsavarTzeth, Seems acceptable, want to open a PR against flathub/shared-modules

AsavarTzeth · 2017-09-25T10:09:37Z

@TingPing Sure, I could do it right away. Should not take long.

thiblahute · 2017-09-25T12:36:34Z

What about building only x64-64 for now? My problem is that I am not sure how to test other arch (and I am not sure I care so much right now).

TingPing · 2017-09-25T13:06:24Z

It is acceptable for now, you probably still want to use the lame version just added to shared-modules though.

TingPing · 2017-09-25T13:09:13Z

org.pitivi.Pitivi.json

+            "sources": [
+                {
+                    "type": "git",
+                    "branch": "1.12.3",


If you want 1.12 now the 3.26 runtime is out, so why wouldn't you use that.

"We need our own build of Gst as we have backported patches that are not in the 1.12 branch and we build quite many more plugins than what is provided in the Sdk."

TingPing · 2017-09-25T13:11:18Z

org.pitivi.Pitivi.json

+            "name": "pitivi",
+            "buildsystem": "meson",
+            "builddir": true,
+            "config-opts": ["--libdir=lib"],


You can drop all of these --libdir=lib now, this was patched in the Sdk.

TingPing · 2017-09-25T13:12:01Z

org.pitivi.Pitivi.json

+                "--disable-libmfx",
+                "--disable-libnpp",
+                "--disable-iconv",
+                "--disable-jni",


It might be more manageable for you to pass --disable-everything.

I am just copy/pasting what is done in the gst-libav statically build ffmpeg submodule.

TingPing · 2017-09-25T13:13:08Z

org.pitivi.Pitivi.json

+        },
+        {
+            "name": "gsound",
+            "ensure-writable": ["easy-install.pth"],


I imagine this doesn't need to be here.

TingPing · 2017-09-25T13:14:00Z

org.pitivi.Pitivi.json

+    "finish-args": ["--socket=x11",
+                    "--socket=pulseaudio",
+                    "--socket=wayland",
+                    "--socket=session-bus",


No reason to pass through entire bus.

#52 (comment)

thiblahute · 2017-10-05T01:38:17Z

Ping?

AsavarTzeth · 2017-10-05T10:41:37Z

You made a typo:

Can't parse 'org.pitivi.Pitivi.json': <data>:466:18: Parse error: unexpected character `,', expected character `]'

thiblahute · 2017-10-05T13:11:49Z

Sorry about that! I am now using lame from the submodule and fixed that issue.

Could you trigger a rebuild?

barthalion · 2017-10-05T14:12:56Z

https://flathub.org/builds/#/builders/1/builds/546

TingPing · 2017-10-05T14:51:23Z

Repository has been created: https://github.com/flathub/org.pitivi.Pitivi

switch from tar to deb

Update qtkeychain to 0.10.0

TingPing reviewed Jul 5, 2017

View reviewed changes

org.pitivi.Pitivi.json Outdated

},

"modules": [

{

"name": "yasm",

Copy link

Member

TingPing Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the Sdk.

TingPing reviewed Jul 5, 2017

View reviewed changes

barthalion requested changes Sep 24, 2017

View reviewed changes

barthalion added awaiting-changes work-in-progress labels Sep 24, 2017

AsavarTzeth mentioned this pull request Sep 25, 2017

Add lame mp3 encoder flathub/shared-modules#9

Merged

TingPing reviewed Sep 25, 2017

View reviewed changes

Create org.pitivi.Pitivi.json

8c9d727

TingPing closed this Oct 5, 2017

fooishbar pushed a commit to fooishbar/flathub that referenced this pull request Apr 8, 2020

Merge pull request flathub#52 from eszlari/deb

ab97c03

switch from tar to deb

tilosp added a commit to tilosp/flathub that referenced this pull request Aug 27, 2020

Merge pull request flathub#52 from flathub/qtkeychain-0.10.0

141e960

Update qtkeychain to 0.10.0

Create org.pitivi.Pitivi.json #52

Create org.pitivi.Pitivi.json #52

Conversation

thiblahute commented Jul 5, 2017 • edited by TingPing

Choose a reason for hiding this comment

thiblahute Jul 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing Jul 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing Jul 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing Jul 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thiblahute Sep 24, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thiblahute commented Jul 6, 2017

thiblahute commented Jul 12, 2017

barthalion commented Jul 12, 2017

TingPing commented Jul 13, 2017

thiblahute commented Jul 14, 2017

purpleidea commented Jul 19, 2017

thiblahute commented Jul 19, 2017 • edited

TingPing commented Jul 19, 2017

purpleidea commented Jul 19, 2017

thiblahute commented Jul 19, 2017

TingPing commented Jul 19, 2017

thiblahute commented Jul 19, 2017

TingPing commented Jul 19, 2017

thiblahute commented Sep 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barthalion commented Sep 24, 2017 • edited

thiblahute commented Sep 24, 2017 • edited

TingPing commented Sep 24, 2017

thiblahute commented Sep 24, 2017 • edited

thiblahute commented Sep 25, 2017

TingPing commented Sep 25, 2017

thiblahute commented Sep 25, 2017

AsavarTzeth commented Sep 25, 2017

TingPing commented Sep 25, 2017

AsavarTzeth commented Sep 25, 2017

thiblahute commented Sep 25, 2017 • edited

TingPing commented Sep 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thiblahute commented Jul 5, 2017 •

edited by TingPing

thiblahute Jul 5, 2017 •

edited

TingPing Jul 5, 2017 •

edited

TingPing Jul 5, 2017 •

edited

TingPing Jul 5, 2017 •

edited

thiblahute Sep 24, 2017 •

edited

thiblahute commented Jul 19, 2017 •

edited

barthalion commented Sep 24, 2017 •

edited

thiblahute commented Sep 24, 2017 •

edited

thiblahute commented Sep 24, 2017 •

edited

thiblahute commented Sep 25, 2017 •

edited

thiblahute commented Oct 5, 2017 •

edited