-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add io.github.wwmm.easyeffects.Presets.LoudnessEqualizer #5227
base: new-pr
Are you sure you want to change the base?
Add io.github.wwmm.easyeffects.Presets.LoudnessEqualizer #5227
Conversation
bot, build io.github.wwmm.easyeffects.Presets.LoudnessEqualizer |
Queued test build for io.github.wwmm.easyeffects.Presets.LoudnessEqualizer. |
Started test build 119847 |
Build 119847 successful
|
Really, to install a few JSON files, this is
I don't think this is fit as a flatpak extension. You might as well ship it with the main package. |
IMO it is somewhat overkill, but still useful especially for more complex presets. Some of the presets have additional IRS or RNNoise model files which are referenced by name in the json files and also need to be placed at the right path. There is a decent variety of presets people have created over the years https://github.com/wwmm/easyeffects/wiki/Community-Presets. I don't think it would be very good to ship them all in the main package. |
Hello. How do you know they are "few" files? If these will be converted, I don't see them few. And no, EasyEffects was not designed to ship presets. If someone makes presets for a specific device which I'm not interested, why should I be forced to have them in the main package? |
Please confirm your submission meets all the criteria
Please also add @Digitalone1 as a collaborator for this repo.
This is the first "preset package" for Easy Effects. The idea is that users can install this package to make "presets" and their associated files available in Easy Effects. Right now users have to download various files straight from GitHub repos which is not the easiest unless you know how GitHub works. Some documentation meant for future packagers is here.
Note, currently this package cannot be fully tested without building from upstream master, most of the changes to add support for these packages have not been released (will be in
7.2.0
). However, the Flathub package has already been changed to support the extension point since we need that to build this preset package, and the files are indeed mounted to the correct path.Main possible issue here is what the name should be. Easy Effects on Flathub is
com.github.wwmm.easyeffects
. But sincecom.github.*
is not accepted for new submissions, these new packages use the extension pointio.github.*
. It is inconsistent and weird but works fine, I am not sure if it is worth EOL rebasingcom.github.wwmm.easyeffects
toio.github.wwmm.easyeffects
.