-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.rustdesk.RustDesk #5233
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b22fcd3
first commit
rustdesk 98746b6
tested, but not sure if need "apt install elfutils", since we failed
rustdesk 25e27ab
prepare for release
rustdesk f160ca8
fix sha256
rustdesk 162171b
modify per PR suggestions
rustdesk 7c9a1bf
format and add x11
rustdesk 6a93a2d
https://docs.flatpak.org/en/latest/sandbox-permissions.html#standard-…
rustdesk e2fc4d4
Update com.rustdesk.RustDesk.json
rustdesk fbc0d95
place before finish-args
rustdesk 8fece68
remove com.rustdesk.RustDesk.metainfo.xml
rustdesk 6698ece
change pam to autotool, no way for xdotool because it is not autotool
rustdesk d466830
--disable-static for pam
rustdesk b31caff
remove /bin/xdotool
rustdesk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| repo | ||
| builddir | ||
| .flatpak-builder |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "shared-modules"] | ||
| path = shared-modules | ||
| url = https://github.com/flathub/shared-modules.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| { | ||
| "id": "com.rustdesk.RustDesk", | ||
| "runtime": "org.freedesktop.Platform", | ||
| "runtime-version": "23.08", | ||
| "sdk": "org.freedesktop.Sdk", | ||
| "command": "rustdesk", | ||
| "rename-desktop-file": "rustdesk.desktop", | ||
| "rename-icon": "rustdesk", | ||
| "cleanup": [ | ||
| "/include", | ||
| "/lib/pkgconfig", | ||
| "/share/gtk-doc", | ||
| "/share/man", | ||
| "*.la", | ||
| "/share/gtk-doc", | ||
| "/bin/bsd*", | ||
| "/bin/xdotool", | ||
| "/libs/libarchive*" | ||
| ], | ||
| "finish-args": [ | ||
| "--share=ipc", | ||
| "--socket=wayland", | ||
| "--socket=fallback-x11", | ||
| "--share=network", | ||
| "--filesystem=home", | ||
| "--device=dri", | ||
| "--socket=pulseaudio", | ||
| "--talk-name=org.freedesktop.Flatpak" | ||
| ], | ||
| "modules": [ | ||
| "shared-modules/libappindicator/libappindicator-gtk3-12.10.json", | ||
| { | ||
| "name": "xdotool", | ||
| "buildsystem": "simple", | ||
| "build-commands": [ | ||
| "make -j4 && PREFIX=./build make install", | ||
| "cp -r ./build/* /app/" | ||
| ], | ||
| "sources": [ | ||
| { | ||
| "type": "archive", | ||
| "url": "https://github.com/jordansissel/xdotool/releases/download/v3.20211022.1/xdotool-3.20211022.1.tar.gz", | ||
| "sha256": "96f0facfde6d78eacad35b91b0f46fecd0b35e474c03e00e30da3fdd345f9ada" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "pam", | ||
| "buildsystem": "autotools", | ||
| "config-opts": [ | ||
| "--disable-static", | ||
| "--disable-selinux" | ||
| ], | ||
| "sources": [ | ||
| { | ||
| "type": "archive", | ||
| "url": "https://github.com/linux-pam/linux-pam/releases/download/v1.3.1/Linux-PAM-1.3.1.tar.xz", | ||
| "sha256": "eff47a4ecd833fbf18de9686632a70ee8d0794b79aecb217ebd0ce11db4cd0db" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "libarchive", | ||
| "buildsystem": "autotools", | ||
| "config-opts": [ | ||
| "--disable-static" | ||
| ], | ||
| "sources": [ | ||
| { | ||
| "type": "archive", | ||
| "url": "https://github.com/libarchive/libarchive/releases/download/v3.5.1/libarchive-3.5.1.tar.gz", | ||
| "sha256": "9015d109ec00bb9ae1a384b172bf2fc1dff41e2c66e5a9eeddf933af9db37f5a" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "rustdesk", | ||
| "buildsystem": "simple", | ||
| "build-commands": [ | ||
| "bsdtar -zxvf rustdesk.deb", | ||
| "tar -xvf ./data.tar.xz", | ||
| "rm -rf usr/share/icons/hicolor/scalable/", | ||
| "cp -r usr/* /app/", | ||
| "mkdir -p /app/bin && ln -s /app/lib/rustdesk/rustdesk /app/bin/rustdesk" | ||
| ], | ||
| "sources": [ | ||
| { | ||
| "type": "file", | ||
| "only-arches": [ | ||
| "aarch64" | ||
| ], | ||
| "url": "https://github.com/rustdesk/rustdesk/releases/download/1.2.4/rustdesk-1.2.4-aarch64.deb", | ||
| "sha256": "4f8be7199a1e8acf0799ce8cea6af08bcf2d6f073a3a098809ac842e3a87d1e8", | ||
| "dest-filename": "rustdesk.deb", | ||
| "x-checker-data": { | ||
| "type": "anitya", | ||
| "project-id": "309593", | ||
| "url-template": "https://github.com/rustdesk/rustdesk/releases/download/$version/rustdesk-$version-aarch64.deb" | ||
| } | ||
| }, | ||
| { | ||
| "type": "file", | ||
| "only-arches": [ | ||
| "x86_64" | ||
| ], | ||
| "url": "https://github.com/rustdesk/rustdesk/releases/download/1.2.4/rustdesk-1.2.4-x86_64.deb", | ||
| "sha256": "43c2f43ad7a8a173fa51093944243f04f003f675e74812644780eee1468b3f9b", | ||
| "dest-filename": "rustdesk.deb", | ||
| "x-checker-data": { | ||
| "type": "anitya", | ||
| "project-id": "309593", | ||
| "url-template": "https://github.com/rustdesk/rustdesk/releases/download/$version/rustdesk-$version-x86_64.deb" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Submodule shared-modules
added at
782d3c
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the metainfo info being installed. You removed it from here, but it is not present in the
.debThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you know not installed? I did see installed from log of flatpak-build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can it be installed when it is not in the deb and nowhere in the manifest as a source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is closed, you do not need to review any more. #5233 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you seem to know better, neither of the line above show the appstream file. So yeah the appstream file isn't installed.