Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add io.liri.Terminal #655

Closed
wants to merge 7 commits into from
Closed

Add io.liri.Terminal #655

wants to merge 7 commits into from

Conversation

plfiorini
Copy link

Terminal app with Material Design from Liri

https://liri.io
https://github.com/lirios/terminal

@plfiorini
Copy link
Author

This depends on #654

@TingPing
Copy link
Member

TingPing commented Oct 3, 2018

I question the value of Flatpaking a terminal without Flatpak specific modifications. It just isn't very useful.

@plfiorini
Copy link
Author

Can you point me to what Flatpak specific changes I should do to the terminal?
As it stands right now I have to poke a hole through the sandbox giving it access to the whole file system and devices, but being an upstream developer I can make this Flatpak friendly.

@TingPing
Copy link
Member

TingPing commented Oct 3, 2018

You would want to run the tty on the host basically, its a non-trivial change. GNOME-Builder does it but I don't know the part of code off-hand: https://github.com/GNOME/gnome-builder/search?q=tty&unscoped_q=tty

@plfiorini
Remove useless cleanup entry
bb9f065
@plfiorini
Remove configure and build scripts
2b9673f 
Since these are very few lines we can move them in the manifest file.
@plfiorini
Reindent
cc0c689
@plfiorini
Do not unset SESSION_MANAGER environment variable
8dd67f4 
This was done to prevent the following message:
Qt: Session management error: Could not open network socket

which is harmless, so there is not much gain in silencing it.
@barthalion
Copy link
Member

Yes, I don't think it's suitable for Flathub as it is now.

@aiamuzz aiamuzz mentioned this pull request Oct 11, 2018
Closed
@plfiorini
Copy link
Author

plfiorini commented Oct 13, 2018 •
edited

Looks like /bin/bash must be executed on the host (with either flatpak-spawn or org.freedesktop.Flatpak.Development).

However only Flatpak can break out of the containment zone so it needs the --allow=devel permission.

@TingPing
Copy link
Member

However only Flatpak can break out of the containment zone so it needs the --allow=devel permission.

No. It needs --talk-name=org.freedesktop.Flatpak

@BrainBlasted
Copy link

BrainBlasted commented Jul 19, 2019 •
edited

Here's a small example of a terminal that can run within Flatpak: https://gitlab.gnome.org/chergert/flatterm

@Saroufim
Copy link

Tilix has been flatpaked on Fedora. This release contains the necessary commits gnunn1/tilix@1.7.0...master

@plfiorini
Copy link
Author

Thanks I have seen the example and I was in the right track.
Will take a look again as soon as I have time.

@flathubbot
Copy link

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

@flathubbot flathubbot closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@plfiorini @TingPing @barthalion @BrainBlasted @Saroufim @flathubbot