New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.freecadweb.FreeCAD (Qt5) #683
Conversation
bot, build org.freecadweb.FreeCAD |
Why do we want multiple versions of the same app? Surely upstream has a recommended variant? |
We don't, that's why the older attempt was closed. |
This is the stable, or Release version, built with Qt 5. The other one was git master built with Qt 4. A nightly option would be ideal. |
bot, build org.freecadweb.FreeCAD |
@eszlari, any plans for a nightly build? It works here with minimal changes to your 0.17 manifest. |
1 similar comment
@eszlari, any plans for a nightly build? It works here with minimal changes to your 0.17 manifest. |
Flathub only ships stable versions. Once the stable flatpak is merged, the upstream could use it as a base to generate nightlies themselves, similarly to how GNOME ships nightly versions of its own applications, separately from Flathub. |
The KDE project also provides nightly builds of their apps: |
Build failed: |
Tcl needs to build before graphviz. I moved Tcl and Tk above graphviz and it builds here. |
bot, build org.freecadweb.FreeCAD |
@@ -0,0 +1,3 @@ | |||
{ | |||
"only-arches": ["x86_64"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fedora builds it for i386 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build fails in the pyside module for i386, arm and aarch64 with same error:
https://flathub.org/builds/#/builders/2/builds/5530
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
:0: error: Unable to retrieve code snippet. [other]
Keeping temporary file: /tmp/QtCore_global_RbFMFE.hpp
shiboken: Error running ApiExtractor.
Command line: --generator-set=shiboken --enable-parent-ctor-heuristic --enable-pyside-extensions --enable-return-value-heuristic --use-isnull-as-nb_nonzero /run/build/pyside2/sources/pyside2/_build/PySide2/QtCore_global.h --include-paths=/app/qt5include:/usr/include/c++/6.4.0:/usr/include/c++/6.4.0/x86_64-unknown-linux:/run/build/pyside2/sources/pyside2/PySide2:/usr/include/ --typesystem-paths=/run/build/pyside2/sources/pyside2/_build/PySide2:/run/build/pyside2/sources/pyside2/PySide2:/run/build/pyside2/sources/pyside2/PySide2/QtCore --output-directory=/run/build/pyside2/sources/pyside2/_build/PySide2/QtCore --license-file=/run/build/pyside2/sources/pyside2/PySide2/QtCore/../licensecomment.txt /run/build/pyside2/sources/pyside2/_build/PySide2/QtCore/typesystem_core.xml --api-version=5.11 --drop-type-entries=
ninja: build stopped: subcommand failed.
�]2;flatpak-builder: Cleanup pyside2�Error: module pyside2: Child process exited with code 1
FB: unmounting rofiles-fuse /srv/buildbot/worker/build-i386-2/org.freecadweb.FreeCAD/.flatpak-builder/rofiles/rofiles-LsMr4v
program finished with exit code 1
elapsedTime=745.785434
If you can point me to a fix, I can enable the other arches.
<releases> | ||
<release version="0.17" date="2018-04-06"></release> | ||
</releases> | ||
</component> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it also have launchable
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added by appstream-compose
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is added because you didn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also tell people not to add categories, because they are added automatically (from the desktop file), so why should this be different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Categories would be tedious duplication, while specifying launchable explicitly is done on single place and just a good practice.
bot, build org.freecadweb.FreeCAD |
bot, build org.freecadweb.FreeCAD |
I don't know, why the last build failed: My local build works and there was a successful build on flathub before: |
OK, I've kicked it again. When it builds green this is lgtm for me. |
bot, build org.freecadweb.FreeCAD |
build is good https://flathub.org/builds/#/builders/2/builds/5971 |
Repository has been created: https://github.com/flathub/org.freecadweb.FreeCAD |
Pinging upstream: @wwmayer @yorikvanhavre
appdata submission: FreeCAD/FreeCAD#1732