Phoenicis PlayOnLinux #803
Conversation
org.phoenicis.playonlinux.json
Outdated
| "sdk-extensions": [ | ||
| "org.freedesktop.Sdk.Extension.openjdk11" | ||
| ], | ||
| "add-build-extensions": { |
There was a problem hiding this comment.
Isn't add-extensions enough here?
There was a problem hiding this comment.
I'm not sure. I had this discussion here: flatpak/flatpak-builder#223. My final understanding was that I should rather use "add-build-extensions".
There was a problem hiding this comment.
I am really not sure if the compat libs should be added as build-extensions. Try changing it to add-extensions.
There was a problem hiding this comment.
@barthalion Any idea why the 32-bit compat extensions are not pulled when installing the Flatpak?
|
testbot, build org.phoenicis.playonlinux |
|
NOTE: This comment was posted by the test instance of buildbot Queued test build for org.phoenicis.playonlinux. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1011 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1011 failed |
|
I have a question regarding access: Can you give the access to the created repository to our whole organization (PhoenicisOrg) instead of only me? |
|
@plata I don't believe we can currently delegate it to an organisation from another project (I think that's a github limitiation but I'd be delighted to be proved wrong), but we can add as many usernames as you'd like. |
|
bot, build org.phoenicis.playonlinux |
|
NOTE: This comment was posted by the test instance of buildbot Queued test build for org.phoenicis.playonlinux. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1012 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1012 failed |
|
Any hints why GL32 is not found in the build? I can build locally and I think Steam uses the same. |
|
testbot, build org.phoenicis.playonlinux |
|
NOTE: This comment was posted by the test instance of buildbot Queued test build for org.phoenicis.playonlinux. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1140 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1140 successful |
|
Ok, so the GL32 version update fixed the build. |
org.phoenicis.playonlinux.json
Outdated
| }, | ||
| "command": "phoenicis-playonlinux", | ||
| "finish-args": [ | ||
| "--filesystem=home", |
There was a problem hiding this comment.
Is the full home directory access really needed?
There was a problem hiding this comment.
We use ~/.Phoenicis only. Is it possible to restrict it to that?
There was a problem hiding this comment.
Yup. :-) You can use --persist=.Phoenicis.
There was a problem hiding this comment.
By the way, there was also a .org.phoenicis.javafx.JavaFXApplication directory created in home by PoL, with webview/localstorage subdirectory and webview/.lock file inside.
There was a problem hiding this comment.
I've just tried this but it doesn't seem to work. I think I must adjust the directory (Java property) we are using somehow. Where is the directory mapped to inside the runtime?
There was a problem hiding this comment.
It works but I don't think it is using ~/.Phoenicis. Try the following: Run Phoenicis PlayOnLinux without flatpak and install an app. Then, run Phoenicis PlayOnLinux with flatpak. You will not see the app. We don't want the apps to reside in the runtime because Phoenicis is just a mean to install them (they do not belong to it). You might want to compare it e.g. to a text editor where you can only save files inside the flatpak.
There was a problem hiding this comment.
One of the major points of Flatpak is that it makes apps (including their file system access) sandboxed. The text editor can use a portal to open/save files, it doesn't need full file system access. Anyway, if you really want the .Phoenicis directory to be unsandboxed, --filesystem=~/.Phoenicis should work fine.
There was a problem hiding this comment.
Running same apps with and without flatpak will create a mess.
We don't want the apps to reside in the runtime because Phoenicis is just a mean to install them (they do not belong to it).
That doesn't makes sense. How those apps are supposed to run without the runtime?
There was a problem hiding this comment.
It works.
I've noticed that the behavior is a bit strange though: You can either select a file or drag and drop it. Drag and drop accepts any file (even from directories which cannot be accessed). The file cannot be opened but that's not really obvious because the drag and drop accepts it first.
|
It looks like that there is some problem with the Wine path, I tried installing 7-Zip and couple other apps using the Flatpak PoL and this was the result:
|
|
Is that with the current manifest or with |
|
With the current manifest. |
|
Just did a clean build and installed and tested Notepad++. I remember having this issue before as well when 32bit was not working correctly. Do you have |
|
Hmm, you're right. I did not have the compat runtime installed. It doesn't seem to be installed automatically when installing from flatpakref. PoL now works fine after installing the 32-bit compat runtime. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1252 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1252 successful |
|
Is it ready to merge? Looks like all reported issues are related to POL itself, not flatpak specifically. |
|
@LeandroStanger I've added cabextract. Adobe Reader is working now. @barthalion I think it can be merged. We will probably find additional dependencies required by certain applications but I guess that's ok. |
|
testbot, build org.phoenicis.playonlinux |
|
NOTE: This comment was posted by the test instance of buildbot Queued test build for org.phoenicis.playonlinux. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1443 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1443 successful |
|
@LeandroStanger we do not have a newer release currently. |
|
@plata could you explain how this project works? Is it possible to install and run wine apps through it in flatpak environment? |
|
@Erick555 yes. If you know PlayOnLinux, Phoenicis PlayOnLinux is the next version. |
|
Great. So |
|
Well, technically the applications are installed to |
|
@plata ... i was trying to test this ... the installation went fine ... but the applications inside (adobe, notepad++ ) just didn't install successfully ... throws up error ... would you entertain errors here on this PR or you want me to wait until the repo gets created and post the issue there ? |
|
@aiamuzz it's probably the best if you open a new issue in https://github.com/PhoenicisOrg/phoenicis. If we find that there's an error in the flatpak, I can fix it here as well but we won't bloat this PR. |
i am testing this flapak build ... that repo is for the normal build isn't it ... i thought this issue could be with the flatpak'ing that's underway here ... anyways ... i think i'll wait until the flathub repo is created for this application and post the issue there ... |
|
The repo is for the software in general. If you have an issue with Phoenicis, it's perfectly fine to open an issue there. Especially if you're not completely sure if it's even related to the flatpak. |
|
bot, build org.phoenicis.playonlinux |
|
NOTE: This comment was posted by the test instance of buildbot Queued test build for org.phoenicis.playonlinux. |
|
NOTE: This comment was posted by the test instance of buildbot Started test build 1498 |
|
NOTE: This comment was posted by the test instance of buildbot Build 1498 successful |
|
Repository has been created: https://github.com/flathub/org.phoenicis.playonlinux @plata, should someone besides you get write access to the repository above? Thanks! |
|
Invitations sent. |
|
Thanks. |
see https://www.playonlinux.com/en/comments-1368.html
Note: We are currently in alpha phase. While the build is reproducible because it uses a zip file matching our released alpha 2 version, I'm not sure if this is sufficient regarding your requirements for stable applications. Nevertheless, I wanted to get your feedback so I can improve the flatpak before the final release.