Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.github.manisandro.gImageReader-qt5 (gImageReader-qt5-flatpak) #810

Closed

Conversation

scx
Copy link

@scx scx commented Jan 13, 2019

@scx
Copy link
Author

scx commented Jan 13, 2019

This app has several variants: Gtk+3, Qt4, Qt5. I decided to submit the Qt5 version, because it seems to be the most polished.

I know that some of you may not like this layout of modules, but I'd rather keep it, because in this way it's easier for me to maintain all these variants.

@scx
Copy link
Author

scx commented Jan 13, 2019

testbot, build com.github.manisandro.gImageReader-qt5

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Queued test build for com.github.manisandro.gImageReader-qt5.

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Started test build 1208

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Build 1208 successful
To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1138/com.github.manisandro.gImageReader-qt5.flatpakref

@nedrichards
Copy link
Member

I see upstream PRs for the appdata: manisandro/gImageReader#397 and a request to participate in flathub manisandro/gImageReader#396

@nedrichards
Copy link
Member

bot, build com.github.manisandro.gImageReader-qt5

@scx
Copy link
Author

scx commented Jan 13, 2019

@scx
Copy link
Author

scx commented Jan 13, 2019

@nedrichards

There are also patches for QtSpell.
manisandro/qtspell#8
manisandro/qtspell#9

@scx
Copy link
Author

scx commented Jan 29, 2019

testbot, build com.github.manisandro.gImageReader-qt5

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Queued test build for com.github.manisandro.gImageReader-qt5.

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Started test build 1723

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Build 1723 successful
To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1643/com.github.manisandro.gImageReader-qt5.flatpakref

Copy link
Member

@barthalion barthalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common issues across your pull requests:

  • [] Modules are unnecesserarily split from the main manifest to external files.
  • [] Pointless installation of README/LICENSE/ChangeLog files.
  • [] Excessive patching, often without any connection to actual flatpak.
  • [] No upstream participation (or app is no longer developed).
  • [] post-install and cleanup are consistently below sources array, making it harder to read your manifests.
  • [] Too wide or unnecessary permissions (--filesystem=home with --persist=, dconf access).
  • [] Separate shell scripts for copying files.

There are also application-specific issues but makes no sense to list them if the list above remains unfixed.

@flathubbot
Copy link

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

@flathubbot flathubbot added the Stale Stale PR, no activity for over a year label Jan 26, 2021
@flathubbot flathubbot closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale PR, no activity for over a year
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants