Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpack-builder make-install-args should not add install automatically #791

Closed
tygerlord opened this issue May 12, 2017 · 2 comments
Closed

Comments

@tygerlord
Copy link

tygerlord commented May 12, 2017

in json defining "make-install-args": [ "something" ] result in command:

make install something

If you want to make different install like defining "install-no-docs" the result become

make install install-no-docs

so you can't redefining which kind of install you want.

Maybe more convenient it's to set "install" by default if make-install-args not defined or replace completly by the new definition.

@alexlarsson
Copy link
Member

Hmm, a more typical use of it would be to do something like make install FOO=bar, where you set FOO=bar as make-install-args, just like the make-args. But I see your point of replacing the install target.

@alexlarsson
Copy link
Member

Maybe we could add a "install-rule": which defaults to "install".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants