Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrades are broken? #90

Closed
4 tasks done
nekohayo opened this issue Mar 4, 2024 · 3 comments
Closed
4 tasks done

Downgrades are broken? #90

nekohayo opened this issue Mar 4, 2024 · 3 comments

Comments

@nekohayo
Copy link

nekohayo commented Mar 4, 2024

  • I have read the README.md document
  • I am using the latest version of Warehouse
  • I am using the Flatpak package of Warehouse
  • I have not found any other opened issues on the same topic

Describe the issue in detail

Demonstration video:
Screencast from 2024-03-04 10-36-51.webm

Steps to reproduce the issue

  1. flatpak install --user org.gnome.gitgDevel with GNOME Nightly version
  2. Try to downgrade to a previous version, without "Disable Upgrades"

Result: nothing happens in practice. Both warehouse and flatpak on the commandline confirm that the package has remained at the latest version.

Terminal output

There was no output in the terminal.

@nekohayo
Copy link
Author

nekohayo commented Mar 4, 2024

Furthermore, if you manually downgrade using the commandline, such as:

flatpak update --user --commit=2c877f18bcdd72bad4d0138625298edb70e90082e76570a1555546a8faa66da3 org.gnome.gitgDevel

…then warehouse's GUI still does not show the latest available commit ID compared to the one you checked out:

image

@heliguy4599
Copy link
Member

heliguy4599 commented Mar 8, 2024

I have figured out the issue, the code for downgrades runs with pkexec at all times, even for --user installed paks. This causes Flatpak to think those --user installed apps are not installed because it's being ran as root. I know how to fix this and it will be resolved shortly. Thanks for bringing this to my attention!

@nekohayo
Copy link
Author

nekohayo commented Mar 9, 2024

Seems like the fix was committed and released now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants