Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport tests of the Python client library #18

Closed
flavray opened this issue Apr 25, 2018 · 4 comments · Fixed by #97
Closed

Backport tests of the Python client library #18

flavray opened this issue Apr 25, 2018 · 4 comments · Fixed by #97
Assignees
Labels

Comments

@flavray
Copy link
Owner

flavray commented Apr 25, 2018

The Avro Python client library has an extensive suite of tests to ensure encoding, decoding, schema reading, etc... are working well.

Let's try and backport them as part of an "integration" test suite for avro-rs

https://github.com/apache/avro/tree/master/lang/py/test

@poros
Copy link
Collaborator

poros commented Apr 26, 2018

@flavray do you want to add it to the first milestones or is it more of a nice to have?

@flavray
Copy link
Owner Author

flavray commented Apr 26, 2018

I kept it out of M1 for now, I think it'd be better to focus on the other issues first.
Don't think this would block the release of M1, but definitely a nice to have though. We'll see how progress is going. :)

@poros
Copy link
Collaborator

poros commented Mar 24, 2019

I had a look at the tests and the vast majority depends on features of the python library that I didn't even know existed (irpc, protocols, tether, etc).

The few ones that are still interesting are https://github.com/apache/avro/blob/master/lang/py/test/test_io.py and https://github.com/apache/avro/blob/master/lang/py/test/test_schema.py.

@poros
Copy link
Collaborator

poros commented Oct 13, 2019

I found a good bunch of test failing which highlighted both bugs and incomplete support of the spec (at least in the areas we are interested in supporting). I opened a bunch of issues to track them.

Together with some regression testing coverage, discovering these issues is probably the best thing we can get out of this whole backporting exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants