Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Double-tap-drag gesture doesn't cause new tiles to load after completion #1602

Open
Tracked by #1529
JaffaKetchup opened this issue Aug 2, 2023 · 7 comments · May be fixed by #1809
Open
Tracked by #1529

[BUG] Double-tap-drag gesture doesn't cause new tiles to load after completion #1602

JaffaKetchup opened this issue Aug 2, 2023 · 7 comments · May be fixed by #1809
Assignees
Labels
bug This issue reports broken functionality or another error P: 3 (low) (Default priority for feature requests) S: core Scoped to the core flutter_map functionality
Milestone

Comments

@JaffaKetchup
Copy link
Member

JaffaKetchup commented Aug 2, 2023

What is the bug?

Performing the double-tap-drag gesture (MapEventSource.doubleTapHold) does not cause new tiles to load after the gesture.

It's the correct behaviour for tiles not to load DURING the gesture, however - they should only load afterward.

How can we reproduce it?

Perform the double-tap-drag gesture on any map to zoom in or out. The previously visible tiles will remain visible, and no new tiles will be loaded.

Do you have a potential solution?

The example application's Interactive Flags test page does not appear to show this event after/during the gesture, meaning it is likely that none is properly emitted during zooming.

Platforms

All

Severity

Obtrusive: Prevents normal functioning but causes no errors in the console

@JaffaKetchup JaffaKetchup added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing P: 1 (important) and removed needs triage This new bug report needs reproducing and prioritizing labels Aug 2, 2023
@JaffaKetchup JaffaKetchup changed the title [BUG] Double tap + drag zoom gesture doesn't cause new tiles to load [BUG] Double-tap-drag gesture doesn't cause new tiles to load during zooming Aug 14, 2023
@flodaniel
Copy link

I am on flutter_map: 5.0.0 and the loading does also not occur once the gesture is completed. I use the gesture to zoom out and after completion the entire map is grey and no server calls to the tiles server are made. Once the user does a simple drag the load happens.

@JaffaKetchup JaffaKetchup changed the title [BUG] Double-tap-drag gesture doesn't cause new tiles to load during zooming [BUG] Double-tap-drag gesture doesn't cause new tiles to load Aug 30, 2023
@JaffaKetchup
Copy link
Member Author

Thanks @flodaniel, I've updated the original issue, as I can reproduce that now as well (I struggled to for some reason previously, but that was probably coincidence).

@josxha josxha self-assigned this Nov 21, 2023
@Robbendebiene
Copy link
Contributor

Robbendebiene commented Nov 27, 2023

I always thought this was more of a feature and not a bug. Since the gesture allows you to zoom in and out very quickly which can cause a lot of tile requests.
Of course after the gesture is finished the tiles should load, but surprisingly that always worked for me.

@josxha
Copy link
Contributor

josxha commented Nov 27, 2023

I always thought this was more of a feature and not a bug.

That's a nice point of view. 😅

Of course after the gesture is finished the tiles should load, but surprisingly that always worked for me.

The problem is that another gesture input is needed until the tiles load after you zoomed with this gesture. I guess most users would do that intuitively if they see that the map doesn't load althrough not every user.

@JaffaKetchup
Copy link
Member Author

Agreed, I think it makes sense for tiles to only load after completion with this gesture.

@josxha
Copy link
Contributor

josxha commented Dec 2, 2023

Some information on how to reproduce the bug:

  1. open the interactive flags page of the demo app
  2. deactivate all movement gestures, you can activate everything else but at least + drag
  3. perform a double tap + drag gesture
double.tap.drag.zoom.mp4

@JaffaKetchup JaffaKetchup changed the title [BUG] Double-tap-drag gesture doesn't cause new tiles to load [BUG] Double-tap-drag gesture doesn't cause new tiles to load after completion Dec 2, 2023
@JaffaKetchup JaffaKetchup added the S: core Scoped to the core flutter_map functionality label Dec 10, 2023
@josxha josxha linked a pull request Dec 14, 2023 that will close this issue
38 tasks
@josxha josxha linked a pull request Jan 23, 2024 that will close this issue
@JaffaKetchup
Copy link
Member Author

This appears to be fixed when performing it on the home page of the example application, but it does still occur in the conditions described by #1602 (comment).

@JaffaKetchup JaffaKetchup added P: 3 (low) (Default priority for feature requests) and removed P: 2 (soon™?) labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error P: 3 (low) (Default priority for feature requests) S: core Scoped to the core flutter_map functionality
Projects
Status: In progress
4 participants