Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: commit notification should only include title #57

Closed
blocktrron opened this issue Oct 21, 2020 · 4 comments
Closed

gitlab: commit notification should only include title #57

blocktrron opened this issue Oct 21, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@blocktrron
Copy link

Currently the notification generated from a new commit includes the full commit message. This is not ideal for a quick notification.

Instead, I think it would be better to only use the commit title for notification purposes.

@fleaz fleaz added bug Something isn't working good first issue Good for newcomers labels Oct 21, 2020
@herbetom
Copy link
Contributor

@fleaz
Copy link
Owner

fleaz commented Oct 21, 2020

@herbetom That's indeed the template which gets used for the commit message but you can't call arbitrary functions like e.g. split in a template.

The two options I see are either a custom template function like firstLine which we then can call in the template or we tackle this in line 411 and split the commit message before loading the data into the template.

@herbetom
Copy link
Contributor

I only looked for maybe 30s for that line. My "idea" was that you could insert instead of Message something diffrent. But since Message isn't used somewhere else i would rename Message in 138 to title and split it in 411 (and also rename it). Or just add another line around 411 for the title and keep Message arround for the future.

@fleaz
Copy link
Owner

fleaz commented Oct 28, 2020

Fixed in #60

@fleaz fleaz closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants