Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat: run stress test on PRs #434

Open
kckeiks opened this issue Mar 8, 2023 · 5 comments
Open

feat: run stress test on PRs #434

kckeiks opened this issue Mar 8, 2023 · 5 comments

Comments

@kckeiks
Copy link
Collaborator

kckeiks commented Mar 8, 2023

It would be useful to be able to run a stress test for the gateway on command.

Suggestion:

  • In a container, run a few nodes, storetheindex, and gateway.
  • Nodes can provide ~3 files of different sizes.
  • Test gateway with oha or some other tool.
  • Display results on PR.

Consider that we should run all participants (indexer, node, gateway) locally in test so that latency (due to its volatility) does not affect the results.

@b0xtch
Copy link
Contributor

b0xtch commented Mar 8, 2023

Could you elaborate on this?

@kckeiks kckeiks changed the title feat(gateway): add CI stress test feat(gateway): run stress test on PRs Mar 9, 2023
@kckeiks
Copy link
Collaborator Author

kckeiks commented Mar 9, 2023

Could you elaborate on this?

👍 I updated the title and added a description.

@kckeiks kckeiks changed the title feat(gateway): run stress test on PRs feat: run stress test on PRs Mar 9, 2023
@b0xtch
Copy link
Contributor

b0xtch commented Mar 9, 2023

Can we create a bench for each crate we want to benchmark? And then just add one command to ci to run all the benches

@kckeiks
Copy link
Collaborator Author

kckeiks commented Mar 9, 2023

I don't have any particular preference atm. I imagine that whoever picks this work can assess. I think the minimum requirement should be that the whole flow (querying indexer, requesting from node) is tested.

@b0xtch
Copy link
Contributor

b0xtch commented Mar 9, 2023

I don't have any particular preference atm. I imagine that whoever picks this work can assess. I think the minimum requirement should be that the whole flow (querying indexer, requesting from node) is tested.

not about preference, whether we decide to do a full benchmark crate to do all of this or are we benchmarking a specific crate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants