Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS to include engineers from both product groups for critical path files #19183

Closed
4 tasks
lukeheath opened this issue May 21, 2024 · 1 comment
Closed
4 tasks

Update CODEOWNERS to include engineers from both product groups for critical path files #19183

lukeheath opened this issue May 21, 2024 · 1 comment
Assignees
@lukeheath
Labels
#g-endpoint-ops Endpoint ops product group #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature
Milestone
4.54.0

Comments

@lukeheath
Copy link
Member

Goal

User story
As a Fleet contributor,
I want to know which files require special consideration or review from other engineers
so that I can make sure not to merge code that could break other workflows.

Context

Changes

Engineering

  • Define critical files that require a special review process.
  • Define engineers from each product group that will be assigned reviewers.
  • Submit PR with changes to codeowners file to implement review requirement.
  • Document the special review process in the Engineering handbook.
@lukeheath lukeheath added story A user story defining an entire feature :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-mdm MDM product group #g-endpoint-ops Endpoint ops product group labels May 21, 2024
@lukeheath lukeheath added this to the 4.51.0-tentative milestone May 22, 2024
@lukeheath lukeheath self-assigned this Jun 12, 2024
@lukeheath lukeheath modified the milestones: 4.53.0, 4.54.0-tentative Jun 24, 2024
@lukeheath lukeheath mentioned this issue Jun 27, 2024
Merged
@fleet-release
Copy link
Contributor

Files interweave,
Shared care in code's vast cloud,
Harmony achieved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeheath lukeheath

Labels
#g-endpoint-ops Endpoint ops product group #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature
Milestone
4.54.0
Development

No branches or pull requests
4 participants
@georgekarrv @lukeheath @fleet-release @sharon-fdm