Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "Missing" hosts count card to dashboard, and set status query param to missing #7589

Closed
10 of 13 tasks
lukeheath opened this issue Sep 6, 2022 · 14 comments
Closed
10 of 13 tasks
Assignees
Labels
~frontend Frontend-related issue. ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists)
Milestone

Comments

@lukeheath
Copy link
Member

lukeheath commented Sep 6, 2022

Problem

I'm an engineer managing thousands of hosts and I'm overwhelmed with tracking this goal:

  • Know how many hosts, and which hosts, are missing.

This makes it hard to troubleshoot why a host is missing. Is the user on a longer vacation? Is the host stolen? Is the host is someone's closet? Is the host broken?

Goals

  1. Know how many hosts are missing.

  2. Know which hosts are missing.

Requirements

  • Fleet Premium users can see how many hosts (count) have been offline in the last 30 days.
  • Fleet Premium users can navigate to a list of hosts filtered by hosts that have been offline in the last 30 days. The user can navigate to this list via the Fleet UI or by pasting a URL in their browsers URL bar.
  • The UI is powered by updates to the GET /host_summary API route.
  • The Fleet API supports adding more intervals in the future. For example, later, we may want to add the ability to see how many hosts have been offline in the last 7 days.
  • On Home page, user can see count of missing hosts that belong to a specific platform.
    • If user selects the Home page card when filtering by missing + platform, they see the Hosts page with only the missing filter applied.

Figma

https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=9223%3A304723

API

  1. Update the GET /host_summary API route
  1. Add new param to GET /hosts to filter by missing hosts.

Parent Epic

Specced by @RachelElysia

Tasks

0 Blocking ticket #7796

  • Move status route param to be a query param

1

  • For Premium and Free: Remove online and offline host cards

2

  • For Premium Users only: Add 2 cards div to homepage that stack at smaller widths

3

Missing host card

  • Display missing host count, along with icon, and tooltip text
  • Tooltip displays: "Hosts that have been offline for 30 days or more."
  • Make area around the icon, count, and name clickable
  • Clicking on the area will redirect to the filter on the manage host page

Image

4

Manage host page

  • Manage host page can be filtered and unfiltered by Missing hosts in the status dropdown
  • Dropdown includes description: "Hosts that have been offline for 30 days or more."

5

Frontend tech

@lukeheath lukeheath added ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists) ~frontend Frontend-related issue. labels Sep 6, 2022
@lukeheath
Copy link
Member Author

@noahtalerman Questions:

  1. Figma says "Remove the “Online” and “Offline” cards from the Home page.". Are we removing these cards from the free version, as well, or only the premium version?

@lukeheath
Copy link
Member Author

@RachelElysia I'm assigning you this issue to finish specifications and bring to estimation. Please prioritize this issue in order to complete specs this week, as we will be bringing this into the next release cycle.

@noahtalerman
Copy link
Member

Are we removing these cards from the free version, as well, or only the premium version?

@lukeheath @RachelElysia, we are removing the "Online" and "Offline" cards for both Fleet Premium (paid) and Fleet Free.

@RachelElysia RachelElysia moved this from 🐣 Designed to 🐥 Specified in ⚗️ ‎‎Roadmap Sep 6, 2022
@lukeheath lukeheath changed the title Add new "Missing" hosts count card to dashboard, and missing_hosts query param when listing all hosts Add new "Missing" hosts count card to dashboard, and set status query param to missing Sep 7, 2022
@RachelElysia
Copy link
Member

8 including the refactor

@lukeheath lukeheath moved this from 🐥 Specified to 🦤 Estimated in ⚗️ ‎‎Roadmap Sep 7, 2022
@lukeheath lukeheath moved this to 🥚 Ready in 🚀 Release Sep 12, 2022
@RachelElysia
Copy link
Member

@noahtalerman

For 1
For Premium and Free: Remove online and offline host cards

I'm assuming the single loading spinner that went across the host summary card AND this online/offline card is now within the host summary card to match the loading spinner of all other cards

@noahtalerman
Copy link
Member

the single loading spinner that went across the host summary card AND this online/offline card is now within the host summary card.

@RachelElysia I think the loading spinner should now be centered across the platforms card, disk space card, and missing hosts card.

For Fleet Free, because there is no disk space card or missing hosts card, I would expect the loading spinner to be centered on the platforms card.

I attached a sketch below to depict this idea. Loading spinner is the white ring.

IMG-9860

What do you think?

@lukeheath
Copy link
Member Author

@RachelElysia Based on feedback from @mna on the backend card, @noahtalerman has redesigned the Figma for this task so that "Missing Hosts" is now a status in the status dropdown and not applied as a filter. This means we can keep using the status=missing query param. Would you please review the Figma and update the specs on this ticket accordingly? Thank you!

@RachelElysia
Copy link
Member

the single loading spinner that went across the host summary card AND this online/offline card is now within the host summary card.

@RachelElysia I think the loading spinner should now be centered across the platforms card, disk space card, and missing hosts card.

For Fleet Free, because there is no disk space card or missing hosts card, I would expect the loading spinner to be centered on the platforms card.

I attached a sketch below to depict this idea. Loading spinner is the white ring.

IMG-9860

What do you think?

SGTM, I'll leave a dev note for other developers who might question why the spinners are different for free and premium since it's not intuitive unless actually looking at the ui

@RachelElysia
Copy link
Member

@RachelElysia Based on feedback from @mna on the backend card, @noahtalerman has redesigned the Figma for this task so that "Missing Hosts" is now a status in the status dropdown and not applied as a filter. This means we can keep using the status=missing query param. Would you please review the Figma and update the specs on this ticket accordingly? Thank you!

Love this idea, will update now.

@lukeheath
Copy link
Member Author

@RachelElysia I've updated the specs on the related backend tickets. When you have a moment would you please review those to make sure they are aligned with your frontend implementation? Thanks!

@noahtalerman
Copy link
Member

I updated the specs so that the help text on the Home and Hosts page reads "Hosts that have been offline for 30 days or more."

@lukeheath

This comment was marked as off-topic.

@RachelElysia RachelElysia moved this from 🐣 In progress to ✨ ‎ ‎In review in 🚀 Release Oct 10, 2022
@RachelElysia
Copy link
Member

RachelElysia commented Oct 10, 2022

@lukeheath @noahtalerman Should this be on team dashboard as well?

@noahtalerman
Copy link
Member

Should this be on team dashboard as well?

Yes! Missing and Low disk space should be displayed if a team is selected. Great catch.

When you get the chance, can you please update the specs for this issue and the Low disk space issue? Thanks :)

This way, Reed will test applying the teams dropdown during testing.

@lukeheath lukeheath moved this from ✨ ‎ ‎In review to ✔️ ‎ ‎‎‎Awaiting QA in 🚀 Release Oct 14, 2022
@xpkoala xpkoala moved this from ✔️ ‎ ‎‎‎Awaiting QA to ✅ Ready for release in 🚀 Release Oct 17, 2022
@lukeheath lukeheath added this to the 4.22.0 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~frontend Frontend-related issue. ~legacy-interface-product-group Associated with the legacy "interface" product group. (No longer exists)
Development

No branches or pull requests

3 participants