-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "Missing" hosts count card to dashboard, and set status
query param to missing
#7589
Comments
@noahtalerman Questions:
|
@RachelElysia I'm assigning you this issue to finish specifications and bring to estimation. Please prioritize this issue in order to complete specs this week, as we will be bringing this into the next release cycle. |
@lukeheath @RachelElysia, we are removing the "Online" and "Offline" cards for both Fleet Premium (paid) and Fleet Free. |
missing_hosts
query param when listing all hostsstatus
query param to missing
8 including the refactor |
For 1 I'm assuming the single loading spinner that went across the host summary card AND this online/offline card is now within the host summary card to match the loading spinner of all other cards |
@RachelElysia I think the loading spinner should now be centered across the platforms card, disk space card, and missing hosts card. For Fleet Free, because there is no disk space card or missing hosts card, I would expect the loading spinner to be centered on the platforms card. I attached a sketch below to depict this idea. Loading spinner is the white ring. What do you think? |
@RachelElysia Based on feedback from @mna on the backend card, @noahtalerman has redesigned the Figma for this task so that "Missing Hosts" is now a status in the status dropdown and not applied as a filter. This means we can keep using the |
SGTM, I'll leave a dev note for other developers who might question why the spinners are different for free and premium since it's not intuitive unless actually looking at the ui |
Love this idea, will update now. |
@RachelElysia I've updated the specs on the related backend tickets. When you have a moment would you please review those to make sure they are aligned with your frontend implementation? Thanks! |
I updated the specs so that the help text on the Home and Hosts page reads "Hosts that have been offline for 30 days or more." |
This comment was marked as off-topic.
This comment was marked as off-topic.
@lukeheath @noahtalerman Should this be on team dashboard as well? |
Yes! Missing and Low disk space should be displayed if a team is selected. Great catch. When you get the chance, can you please update the specs for this issue and the Low disk space issue? Thanks :) This way, Reed will test applying the teams dropdown during testing. |
Problem
I'm an engineer managing thousands of hosts and I'm overwhelmed with tracking this goal:
This makes it hard to troubleshoot why a host is missing. Is the user on a longer vacation? Is the host stolen? Is the host is someone's closet? Is the host broken?
Goals
Know how many hosts are missing.
Know which hosts are missing.
Requirements
GET /host_summary
API route.Figma
https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=9223%3A304723
API
GET /host_summary
API routemissing_30_days_count
property to theGET /host_summary
endpoint #7587GET /hosts
to filter by missing hosts.missing
value to existingstatus
URL parameter at theGET /hosts
endpoint #7588Parent Epic
Specced by @RachelElysia
Tasks
0 Blocking ticket #7796
1
2
3
Missing host card
4
Manage host page
5
Frontend tech
The text was updated successfully, but these errors were encountered: