Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI – Activity feed webhook automation modal #19285

Merged
merged 11 commits into from
May 28, 2024

Conversation

jacobshandling
Copy link
Contributor

This PR is the direct-to-main replacement for #19096, which merged to a now-defunct feature branch

Addresses #19052

  • update config, webhook interfaces, mock

  • clean up deprecated Sandbox code

  • implement Activity Feed Automations Modal and associated logic

  • Also addresses White scrollbars always appear on modal backgrounds #19284
    Screenshot-2024-05-24-at-21725PM

  • Changes file added for user-visible changes in changes/

  • Manual QA for all new/changed functionality

})}
</SandboxGate>
);
const MDMCard = useInfoCard({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed SandboxGate

);
};

const onSubmitActivityFeedAutomationsModal = useCallback(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only new code here – onSoftwarequeryChange, onSoftwareTabChange, and isCollectingInventory are just moved around

@jacobshandling jacobshandling merged commit a5ab221 into main May 28, 2024
9 checks passed
@jacobshandling jacobshandling deleted the 19052-activity-feed-webhooks-FE branch May 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants