-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI – Activity feed webhook automation modal #19285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobshandling
commented
May 28, 2024
})} | ||
</SandboxGate> | ||
); | ||
const MDMCard = useInfoCard({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed SandboxGate
jacobshandling
commented
May 28, 2024
); | ||
}; | ||
|
||
const onSubmitActivityFeedAutomationsModal = useCallback( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only new code here – onSoftwarequeryChange
, onSoftwareTabChange
, and isCollectingInventory
are just moved around
gillespi314
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the direct-to-
main
replacement for #19096, which merged to a now-defunct feature branchAddresses #19052
update config, webhook interfaces, mock
clean up deprecated Sandbox code
implement Activity Feed Automations Modal and associated logic
Also addresses White scrollbars always appear on modal backgrounds #19284
Changes file added for user-visible changes in
changes/
Manual QA for all new/changed functionality