Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend - Webhooks for Global Activity Feed #19052

Closed
11 tasks done
jacobshandling opened this issue May 15, 2024 · 2 comments
Closed
11 tasks done

Frontend - Webhooks for Global Activity Feed #19052

jacobshandling opened this issue May 15, 2024 · 2 comments
Assignees
@jacobshandling
Labels
#g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone
4.51.0

Comments

@jacobshandling
Copy link
Contributor

jacobshandling commented May 15, 2024 •
edited
Loading

https://www.figma.com/file/Ijbt9xhgXZFAu376qCZQBS/%2314722-Webhooks-for-global-activity?type=design&node-id=0%3A1&mode=design&t=fKX9LjhMMDzCTg0s-1

  • Manage automations button at top right of dashboard activity feed
    • Visible to Global admins and maintainers when “All teams” is selected
    • Opens Activity Feed Automations Modal (AFAM)
  • AFAM
    • When disabled, all other form fields are disabled
    • Show/hide example payload button
    • Example payload
    • On save
      • Updates config
      • success flash
      • error flash
@jacobshandling jacobshandling added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels May 15, 2024
@jacobshandling jacobshandling self-assigned this May 15, 2024
@jacobshandling jacobshandling mentioned this issue May 16, 2024
Merged
jacobshandling added a commit that referenced this issue May 21, 2024
@jacobshandling
UI – Activity feed webhook automations (#19096)
b54ac47 
## Addresses #19052 
- update config, webhook interfaces, mock
- clean up deprecated Sandbox code
- implement Activity Feed Automations Modal and associated logic

![Screenshot-2024-05-16-at-35532PM](https://github.com/fleetdm/fleet/assets/61553566/0f4db1da-08c4-45a9-9e95-8ca150dba2b1)


~- [ ] Changes file added for user-visible changes in `changes/`~ will
include with full feature branch merge
~- [ ] Manual QA for all new/changed functionality~ – this branch is
ready to plug-and-play with the backend changes, meaning it will _not_
successfully build on its own until the expected fields are returned
from the API. One can easily replace relevant lines with mocked data for
experimentation if so desired.

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@lukeheath lukeheath added this to the 4.51.0-tentative milestone May 22, 2024
@jacobshandling jacobshandling mentioned this issue May 24, 2024
Merged
2 tasks
jacobshandling added a commit that referenced this issue May 28, 2024
@jacobshandling
UI – Activity feed webhook automation modal (#19285)
a5ab221 
_This PR is the direct-to-`main` replacement for #19096, which merged to
a now-defunct feature branch_

## Addresses #19052 

- update config, webhook interfaces, mock
- clean up deprecated Sandbox code
- implement Activity Feed Automations Modal and associated logic
- Also addresses #19284 

![Screenshot-2024-05-24-at-21725PM](https://github.com/fleetdm/fleet/assets/61553566/1afc62f7-eeb3-49a8-a545-b971f2a19921)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@xpkoala
Copy link
Contributor

xpkoala commented May 31, 2024

@jacobshandling The feature is functioning properly, but it looks like some of the example text is missing from Figma

Figma:

image

main

image

@jacobshandling jacobshandling mentioned this issue May 31, 2024
Merged
1 task
jacobshandling added a commit that referenced this issue May 31, 2024
@jacobshandling
UI - add help text to activity feed automations modal (#19423)
b200654 
## Follow up for #19052 
<img width="941" alt="Screenshot 2024-05-31 at 10 49 38 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/8ace21c0-fc7f-4bea-bff3-80f0afafdf5c">

- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@fleet-release
Copy link
Contributor

Dashboard's lively stream,
Webhooks sow seeds of change,
Ease blooms in code's gleam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
#g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone
4.51.0
Development

No branches or pull requests
4 participants
@lukeheath @xpkoala @jacobshandling @fleet-release