-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce simulation file size for mode solver #1191
Comments
So this would involve potentially finding the part of the custom medium (or several custom mediums) that intersect the |
I wonder if (in the spirit of the
do you have something similar in heat solver? |
Assigning @dbochkov-flexcompute so that someone is responsible for this; it's a long-term thing though. I put it for 2.6 for now. |
Yeah, that makes sense to me. Probably we can expand it to do the following things:
also care must be taken not to mess up symmetry Another part of this task would be incorporating this into our webapi call, so that something like this happens:
One caveat: using a reduced simulation region might result in a slightly different computational grid, but it's probably ok because it won't be used for mode injection or decomposition.
I might get on top of this soonish, because it might be quite important for heat solver usability |
I have a working prototype and now thinking how to split it between
Any thoughts @tylerflex @momchil-flex ? |
I'd say overall just depends on how useful this Simulation.subsection would be and if it's worth your time. Regarding the specific implementation of that:
I'd say transfer BCs with option to overwrite them yea.
That sounds reasonable on me.
I might suggest simplifying this: if the subsection box is exactly centered at the symmetry, then the new simulation ha the same symmetry. If the subsection box intersects the symmetry plane but isn't centered, error? What you suggest probably works, but might be an edge case we dont need to handle and it could indicate someone setting something up incorrectly? |
Yeah, I think this makes sense and is easier too, thanks! |
Should we close this now @dbochkov-flexcompute |
yeah |
In case of large simulations with custom media the total size of simulation file can be quite big. When calling server side mode solver, the entire simulation size is uploaded, however, typically only a small subset of data is required. Maybe we could introduce a way that uploads only the required data.
The text was updated successfully, but these errors were encountered: