sim.plot_structures no longer plotting right.

[tomflexcompute]

A user found that in 2.5.2, sim.plot_structures no longer finds the right bounds while sim.plot works well.

According to Weiliang, it's potentially related to the introduction of scene. Do you think it's the case @dbochkov-flexcompute ? If so, can we fix it in the next version?

[dbochkov-flexcompute]

wanted to double check one thing: before 2.5.0 (when scene was introduced), .plot_structures() and .plot_structures_eps() would select plotting domain as simulation size + PLOT_BUFFER (the same default buffer when we plot individual geometries). However, I am not sure if this was intended as I see that default plot bounds are set to simulation size + PML size when this line is executed

tidy3d/tidy3d/components/simulation.py

Line 1587 in f60bf47

ax = self._set_plot_bounds(ax=ax, x=x, y=y, z=z, hlim=hlim, vlim=vlim)

but then this is overwritten a few lines later which sets plotting bounds as simulation size + PLOT_BUFFER

tidy3d/tidy3d/components/simulation.py

Line 1591 in f60bf47

ax = self.add_ax_labels_lims(axis=axis, ax=ax)

The difference is very minor, but still wanted to double check what I should set the default plotting domain to? I guess options are:

• simulation size + PLOT_BUFFER
• simulation size + PML size
• simulation size

[tomflexcompute]

Thanks @dbochkov-flexcompute . I don't have a very strong opinion on this but simulation size + PML size makes sense to me but I'll have @momchil-flex and others share their thoughts.

[momchil-flex]

I don't really remember what the PLOT_BUFFER was for - maybe @tylerflex does. size + PML size also makes sense to me.

[tylerflex]

yea I think blot buffer was from way long ago and we can just do size + PML