Skip interpolation validator if tracing autograd boxes #1736
Conversation
tidy3d/components/data/data_array.py
Outdated
| """ | ||
| # skip this validator if currently tracing for autograd because | ||
| # self.values will be dtype('object') and not interpolatable | ||
| if isbox(self.values.ravel()[0]): |
There was a problem hiding this comment.
Thanks @yaugenst-flex
My only concern is whether .ravel() will be slow, but I suppose interpolation already in the validator will be a bit slow too. There's also self.values.flat[0], I'm not sure the difference but this might be a little faster as it returns an iterator rather than a new array.
Another option is that I think when there are tracers in the values, then the full traced ArrayBox will be in self.attrs[AUTOGRAD_KEY], so we could check if AUTOGRAD_KEY in self.attrs:, although it's probably less robust.
There was a problem hiding this comment.
another option could be to skip if self.values.dtype == object
There was a problem hiding this comment.
There's also self.values.flat[0], I'm not sure the difference but this might be a little faster as it returns an iterator rather than a new array.
ravel() only returns a copy if necessary (i.e., the array is not contiguous), but yeah .flat[0] is probably better.
another option could be to skip if self.values.dtype == object
wanted to avoid this since I think it's too general, the validator should generally error on dtype=object
There was a problem hiding this comment.
ok sounds good to me (re flat vs ravel vs dtype).
yaugenst-flex
force-pushed
the
yaugenst-flex/fix-interp-validator
branch
from
09de424
to
626520a
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/fix-interp-validator
branch
from
626520a
to
666c61a
Compare
|
@momchil-flex fixed. this is ready to merge then i think |
Fixes #1734
Note: Checking for
ArrayBoxspecifically because the validator should still fail in other instances whereself.valuesmight have the wrongdtype.