Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1684 broke autograd tests #1734

Closed
yaugenst-flex opened this issue Jun 3, 2024 · 2 comments
Closed

#1684 broke autograd tests #1734

yaugenst-flex opened this issue Jun 3, 2024 · 2 comments
Assignees
@tylerflex @yaugenst-flex

Comments

@yaugenst-flex
Copy link
Contributor

The new interp validator in #1684 broke autograd tests, as arrays of dtype object (during bw pass?) can not be interpolated. @marc-flex
@momchil-flex
Copy link
Collaborator

Oh, yikes, I guess the CI only passed before the autograd PR was merged. Can we just avoid the validator for that dtype?

@tylerflex
Copy link
Collaborator

Can we just avoid the validator for that dtype?

That would be fine

This was referenced Jun 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tylerflex tylerflex

@yaugenst-flex yaugenst-flex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momchil-flex @tylerflex @yaugenst-flex