Literal defined as ccd_real_t #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A literal in a type-deduced function call was declared as a double literal (e.g., `1.`). When ccd_real_t is a double, this is fine. But when it is a float, the type cannot be successfully deduced. We correct this by explicitly calling it out as a ccd_real_t-typed value.
SeanCurtis-TRI
commented
Feb 12, 2019
There was a problem hiding this comment.
+@sherm1 for review, please.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)
sherm1
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Thanks, Sean -- 
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Compiles fine here... Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A literal in a type-deduced function call was declared as a
doubleliteral (e.g.,1.). Whenccd_real_tis adouble, this is fine. But when it is afloat, the type cannot be successfully deduced.We correct this by explicitly calling it out as a
ccd_real_t-typed value.resolves #372
This change is