Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Signature not displaying in Firefox #7683

Closed
11 tasks
JessicaMarine opened this issue Jan 28, 2021 · 6 comments
Closed
11 tasks

BUG: Signature not displaying in Firefox #7683

JessicaMarine opened this issue Jan 28, 2021 · 6 comments
Assignees
Labels

Comments

@JessicaMarine
Copy link

JessicaMarine commented Jan 28, 2021

Describe the Bug
The signature of an IRS attorney is not showing up in Firefox. It displays on the PDF in Chrome.

View of document in Chrome:
image.png

View of same document in Firefox:
image.png

Business Impact/Reason for Severity

In which environment did you see this bug?

Who were you logged in as?

What were you doing when you discovered this bug? (Using the application, demoing, smoke tests, testing other functionality, etc.)

To Reproduce
Steps to reproduce the behavior:

  1. Go to 5752-20S in Chrome
  2. Click on Proposed Stipulated Decision
  3. Note that the R's counsel signature is on the document
  4. Go to 5752-20S in Firefox
  5. Click on Proposed Stipulated Decision
  6. Note that the R's counsel signature is not on the document

Expected Behavior
*PDFs (including signatures on them) should display consistently across browsers

Actual Behavior

  • Signature is not displaying on PDF in Firefox
  • Signature is displaying on PDF in Chrome

A clear and concise description of what actually happened.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Cause of Bug, If Known

Process for Logging a Bug:

  • Complete the above information
  • Add a severity tag (Critical, High Severity, Medium Severity or Low Severity). See below for priority definition.

Severity Definition:

  • Critical Defect
    Blocks entire system's or module’s functionality
    No workarounds available
    Testing cannot proceed further without bug being fixed.

  • High-severity Defect
    Affects key functionality of an application
    There's a workaround, but not obvious or easy
    App behaves in a way that is strongly different from the one stated in the requirements

  • Medium-severity Defect
    A minor function does not behave in a way stated in the requirements.
    Workaround is available and easy

  • Low-severity Defect
    Mostly related to an application’s UI
    Doesn't need a workaround, because it doesn't impact functionality

Definition of Done (Updated 4-14-21)

Product Owner

  • Bug fix has been validated in the Court's test environment

Engineering

  • Automated test scripts have been written
  • Field level and page level validation errors (front-end and server-side) integrated and functioning
  • Verify that language for docket record for internal users and external users is identical
  • New screens have been added to pa11y scripts
  • All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html
  • READMEs, other appropriate docs, JSDocs and swagger/APIs fully updated
  • UI should be touch optimized and responsive for external only (functions on supported mobile devices and optimized for screen sizes as required)
  • Interactors should validate entities before calling persistence methods
  • Code refactored for clarity and to remove any known technical debt
  • Deployed to the Court's test environment
@JessicaMarine JessicaMarine added bug Something isn't working Low Severity labels Jan 28, 2021
@matthopson
Copy link

Just a note for this: IF this signature is applied electronically and is considered a layer in the document like the eSigned sig, it may be the same issue we moved away from in the other viewer implementation. That old implementation relied on pdf.js (by Mozilla), which is also used natively in Firefox.

@kkoskelin
Copy link

Good news on this front: the pdf.js library appears to have implemented signatures per mozilla/pdf.js#13214
However, I cannot say when this code will make its way into a Firefox release, or if perhaps it is already working.
@JessicaMarine can we identify an actual real-life PDF with this kind of e-signature that is safe to be provided here? One that developers can use for testing against chrome/edge/firefox/safari?

@kkoskelin kkoskelin self-assigned this May 24, 2021
@kkoskelin kkoskelin added the Blocked The issue is blocked label May 24, 2021
@JessicaMarine
Copy link
Author

@JessicaMarine JessicaMarine removed the Blocked The issue is blocked label May 25, 2021
@kkoskelin
Copy link

kkoskelin commented May 25, 2021

The above link has a PDF which has been altered (sanitized?) in some manner. However, this one appears to have the signature we desire for purposes of testing: esig.pdf

@calixteman
Copy link

Signature display is available in Firefox beta (89) so next release will have it.

@kkoskelin
Copy link

Many thanks, @calixteman for the update! Since a fix is forthcoming for Firefox and the number of affected internal users (those for whom it is most critical to see signatures) are using chrome/edge, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants