Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define
todefinition
incomponent.js
component.js
's internaldefine
function can be mixed up with AMD's use ofdefine
as seen in the amd-optimize bug.Background
I ran across an error when using
amd-optimize
where it incorrectly thought that internal function calleddefine
was a request for AMD dependencies. I've opened a PR there but have not received word that it will be merged/considered.My thought is that changing Flight will make it more flexible and not use the "reserved word"
define
.Feedback welcomed.