Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename define to definition #339

Closed
wants to merge 1 commit into from
Closed

Conversation

c0
Copy link
Contributor

@c0 c0 commented Feb 10, 2015

  • Rename define to definition in component.js

component.js's internal define function can be mixed up with AMD's use of define as seen in the amd-optimize bug.

Background

I ran across an error when using amd-optimize where it incorrectly thought that internal function called define was a request for AMD dependencies. I've opened a PR there but have not received word that it will be merged/considered.

My thought is that changing Flight will make it more flexible and not use the "reserved word" define.

Feedback welcomed.

- Rename `define` to `definition` in `component.js`

`component.js`'s internal `define` function can be mixed up with
requirejs's use of `define` as seen in  [amd-optimize](scalableminds/amd-optimize#42)
@tgvashworth
Copy link
Contributor

Hi @c0. Huh, this is interesting — thanks for bringing it up.

Perhaps we could call it defineComponent — the noun definition is a funny one.

As an aside, this would be good to get out in v1.x release, so could you put it up against that branch instead? Thanks!

@c0
Copy link
Contributor Author

c0 commented Feb 10, 2015

Boom: #340

@c0 c0 closed this Feb 10, 2015
@c0 c0 deleted the cw/rename_define branch February 10, 2015 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants