Rename define to defineComponent #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `define` to `defineComponent` in `component.js` `component.js`'s internal `define` function can be mixed up with AMD's use of `define` as seen in [amd-optimize](scalableminds/amd-optimize#42)
|
Thanks very much for moving this over. So now the question is: do we merge this or wait for amd-optimize to fix their bug? |
|
I wonder if only this one should be merged. I'm not fully versed in the AMD spec, but is |
|
That's a good question. It's possible that we'll move to CommonJS for Will merge now but I probably won't get a release out until next week. |
tgvashworth
added a commit
that referenced
this pull request
Feb 12, 2015
Rename define to defineComponent
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definetodefineComponentincomponent.jscomponent.js's internaldefinefunction can be mixed up with AMD's use ofdefineas seen in the amd-optimize bug.Background
I ran across an error when using
amd-optimizewhere it incorrectly thought that internal function calleddefinewas a request for AMD dependencies. I've opened a PR there but have not received word that it will be merged/considered.My thought is that changing Flight will make it more flexible and not use the "reserved word"
define.Feedback welcomed.