This repository has been archived by the owner on May 14, 2018. It is now read-only.
Allow local variables named define to be called **AST Feedback Wanted**
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling a nested local variable named `define` no longer triggers the `A module must not have more than one anonymous 'define' calls.` as long as there are no arguments.
c0
added a commit
to rentpath/flight
that referenced
this pull request
Feb 10, 2015
- Rename `define` to `definition` in `component.js` `component.js`'s internal `define` function can be mixed up with requirejs's use of `define` as seen in [amd-optimize](scalableminds/amd-optimize#42)
c0
added a commit
to rentpath/flight
that referenced
this pull request
Feb 10, 2015
- Rename `define` to `defineComponent` in `component.js` `component.js`'s internal `define` function can be mixed up with AMD's use of `define` as seen in [amd-optimize](scalableminds/amd-optimize#42)
|
Hi, thanks for submitting this PR and sorry for the long wait. I think your implementation and detection of error is quite good :-) |
|
Thanks! |
|
:-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defineno longer triggers theA module must not have more than one anonymous 'define' calls.as long as there are no arguments.While using FlightJS,
amd-optimizewas throwing a false positive error when checking for anonymousdefinecalls.I do not know enough about how to detect this scenario with AST, so this my naive attempt. Is there a better way?