Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

The test for mod_fmpz fails #74

Closed
albinahlback opened this issue Apr 5, 2022 · 8 comments
Closed

The test for mod_fmpz fails #74

albinahlback opened this issue Apr 5, 2022 · 8 comments

Comments

@albinahlback
Copy link
Contributor

Output:

mod_fmpz....FAIL: Reducing without denominator
f = 1/3*x^3+1/3*x-1/3
a = 0
b = 0
c = 0
n = 39613779025677300323867164673

Fails both on FLINT branches trunk and flint-2.8, with Antic being current state of trunk.

@albinahlback
Copy link
Contributor Author

Can you verify that you get the same result, @thofma?

@thofma
Copy link
Contributor

thofma commented Apr 5, 2022

I don't have the setup to build flint/antic locally at the moment. Could you check @tthsqe12?

@tthsqe12
Copy link

tthsqe12 commented Apr 5, 2022

I get the exact same failure.

@albinahlback
Copy link
Contributor Author

albinahlback commented Apr 6, 2022

I've tried to go back in the commits to the beginning of last year, but the test still fails.

@albinahlback
Copy link
Contributor Author

Seems to be this line
https://github.com/wbhart/antic/blob/e6f8bf1b640f7d1d5370eff542e23aa0ba80dd99/nf_elem/mod_fmpz.c#L86
that causes the problem: The only time it is ran is when the test fails.

@wbhart
Copy link
Collaborator

wbhart commented Apr 25, 2022

What is wrong with the line? Elsewhere you seemed to indicate it could not be causing the issue.

@albinahlback
Copy link
Contributor Author

Executing that line resulted in an error, but that was resolved with the PR. As I noticed, it was no problem with the function in itself, but rather one of its dependencies. Sorry for the confusion.

@wbhart
Copy link
Collaborator

wbhart commented Apr 25, 2022

Thanks for clarifying.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants