You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Util in commons has some strange visibility. It is a public class but all of its methods are package private. Perhaps it should be package private as well or set the methods to to public if you intend other devs to use the methods to make sheets.
Also the Constructor should be made private and throw an AssertException.
The text was updated successfully, but these errors were encountered:
Oops, yeah that was supposed to be package level only as well. Kind of
threw stuff in there without really putting any thought into it. Generally
don't want other developers to rely on those methods though, maaaaybe
exposing the outline provider implementation. We're probably going to do a
bugfix release pretty soon for the two other existing issues, so I'll clean
it up before then.
On Fri, Jul 24, 2015 at 9:50 AM Nathan Schwermann notifications@github.com
wrote:
Util in commons has some strange visibility. It is a public class but all
of its methods are package private. Perhaps it should be package private as
well or set the methods to to public if you intend other devs to use the
methods to make sheets.
Also the Constructor should be made private and throw an AssertException.
—
Reply to this email directly or view it on GitHub #24.
Util in commons has some strange visibility. It is a public class but all of its methods are package private. Perhaps it should be package private as well or set the methods to to public if you intend other devs to use the methods to make sheets.
Also the Constructor should be made private and throw an AssertException.
The text was updated successfully, but these errors were encountered: