Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util visibility #24

Closed
nschwermann opened this issue Jul 24, 2015 · 1 comment
Closed

Util visibility #24

nschwermann opened this issue Jul 24, 2015 · 1 comment

Comments

@nschwermann
Copy link

Util in commons has some strange visibility. It is a public class but all of its methods are package private. Perhaps it should be package private as well or set the methods to to public if you intend other devs to use the methods to make sheets.

Also the Constructor should be made private and throw an AssertException.

@ZacSweers
Copy link
Contributor

Oops, yeah that was supposed to be package level only as well. Kind of
threw stuff in there without really putting any thought into it. Generally
don't want other developers to rely on those methods though, maaaaybe
exposing the outline provider implementation. We're probably going to do a
bugfix release pretty soon for the two other existing issues, so I'll clean
it up before then.
On Fri, Jul 24, 2015 at 9:50 AM Nathan Schwermann notifications@github.com
wrote:

Util in commons has some strange visibility. It is a public class but all
of its methods are package private. Perhaps it should be package private as
well or set the methods to to public if you intend other devs to use the
methods to make sheets.

Also the Constructor should be made private and throw an AssertException.


Reply to this email directly or view it on GitHub
#24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants