-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue Playing Even During Animation #27
Comments
Are you referring to the playback of the image view pausing e.g. when it's inside a scroll view and the user scrolls? |
Yes. |
The relevant comment in code is here: https://github.com/Flipboard/FLAnimatedImage/blob/master/FLAnimatedImageDemo/FLAnimatedImage/FLAnimatedImageView.m#L147 It's on the to do list to investigate whether it's zero-risk to enable. If you already want to give it a try, just change the run loop mode to Let me know! |
I did change that already, and it didn't seem to make a difference, other than the fact that the GIFs don't pause. The comment you linked me to just says that "we don't support…", so I'm wondering what the reason behind that is. |
It was a defensive choice because I saw some issues at the time (performance, run loop, ...), which might not be valid anymore and I'll revisit. In the meantime, feel free to use it with the CommonModes and enjoy continuous animation playback! :) If you have any concerns or thoughts, let me know. Closing this issue as a dupe of #6 |
Looked through the project and comments where I thought I'd find something, but I've been unable to find anything that explains why the GIFs are paused during an animation. This is the only flaw with the class as far as I can tell, everything else works perfectly.
The text was updated successfully, but these errors were encountered: